Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline-comment doesn't appear immediately when using Open Changes in Solution #1233

Closed
jcansdale opened this Issue Sep 18, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@jcansdale
Copy link
Collaborator

jcansdale commented Sep 18, 2017

  • GitHub Extension for Visual Studio version: 2.3.4.40 (dev)
  • Visual Studio version: 2015

What happened (with steps, logs and screenshots, if possible)

  1. Open https://github.com/grokys/PullRequestSandbox/ in VS
  2. Open details of PR 29 in GitHub pane
  3. View Changes in Solution on Guard.cs
  4. Try to add comment on line 15

After clicking Comment, the inline-comment doesn't show up immediately.
If I close and reopen Guard.cs, the comment appears on the correct line.

I believe this regression was introduced with #1230.

//cc @grokys

@meaghanlewis meaghanlewis modified the milestone: 2.3.4.40 Sep 18, 2017

@meaghanlewis

This comment has been minimized.

Copy link
Contributor

meaghanlewis commented Sep 19, 2017

Hey @jcansdale im unable to repro this issue as well. I'm wondering what's different about our machines. Can you still repro this?

What about you @grokys?

@jcansdale

This comment has been minimized.

Copy link
Collaborator Author

jcansdale commented Sep 21, 2017

Hi @meaghanlewis, yes I'm still seeing this. I think it might be specific to View Changes in Solution (which requires the PR branch to be checked out). In my description above, I'd written Open Changes in Solution, which was wrong! Maybe that's why you couldn't repro it?

@meaghanlewis

This comment has been minimized.

Copy link
Contributor

meaghanlewis commented Sep 21, 2017

Okay, thanks @jcansdale 👍 . This does seem to be specific to View Changes in Solution.

@meaghanlewis

This comment has been minimized.

Copy link
Contributor

meaghanlewis commented Oct 18, 2017

I believe this issue is fixed by: #1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.