New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors opening a pull request: "Failed to nmap..." #1244

Closed
bwishan opened this Issue Oct 2, 2017 · 11 comments

Comments

Projects
None yet
5 participants
@bwishan

bwishan commented Oct 2, 2017

Environment:
GitHub Enterprise
Git repo has two remotes. One is a fork.
VS 2017 15.3.5
GitHub.VisualStudio 2.3.3.38

Repro:

  1. Open GitHub repo
  2. Click Pull Requests
  3. Select the fork remote
  4. Select any pull request

Expected:
Opens PR

Actual:
Briefly spins and then displays the following error:

'Failed to nmap. No data written: Not enough storage is available to process this command.'

@grokys

This comment has been minimized.

Contributor

grokys commented Oct 3, 2017

Hi @bwishan, we've had another report of this problem but have been unable to reproduce. Does this happen on any public repositories that we could access?

@bwishan

This comment has been minimized.

bwishan commented Oct 3, 2017

I'll see if I can give it a try later this morning. @grokys

@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Oct 5, 2017

@bwishan I've uploaded a build of GitHub for Visual Studio with a possible fix. Could you install it and let me know if it improves the situation?

You can find it here: #1248 (comment)

@machish

This comment has been minimized.

machish commented Oct 6, 2017

Hi, I just hit a similar case when I tried to open up a Pull Request to review the code. I attached ntsd, and the operation seems to be exhausting the heap. Note how Heap goes up to 1.5 GB, and that the largest Free region is only 15 MB!

Coincidentally, I work with @bwishan , so could it potentially be something with our GitHub enterprise installation?

Before:

0:000> !address -summary

--- Usage Summary ---------------- RgnCount ----------- Total Size -------- %ofBusy %ofTotal
Free                                   1004          59d36000 (   1.404 GB)           35.09%
<unknown>                              2511          49def000 (   1.154 GB)  44.45%   28.86%
Image                                  7226          29a36000 ( 666.211 MB)  25.06%   16.27%
MappedFile                              158          1e902000 ( 489.008 MB)  18.39%   11.94%
Heap                                    457           f324000 ( 243.141 MB)   9.15%    5.94%
Stack                                   249           4d60000 (  77.375 MB)   2.91%    1.89%
Other                                     7             bc000 ( 752.000 kB)   0.03%    0.02%
TEB                                      82             52000 ( 328.000 kB)   0.01%    0.01%
PEB                                       1              1000 (   4.000 kB)   0.00%    0.00%

--- Type Summary (for busy) ------ RgnCount ----------- Total Size -------- %ofBusy %ofTotal
MEM_PRIVATE                            3266          5d7de000 (   1.461 GB)  56.26%   36.52%
MEM_IMAGE                              7261          2a090000 ( 672.563 MB)  25.30%   16.42%
MEM_MAPPED                              163          1e9bc000 ( 489.734 MB)  18.42%   11.96%

--- State Summary ---------------- RgnCount ----------- Total Size -------- %ofBusy %ofTotal
MEM_COMMIT                             8831          94bc3000 (   2.324 GB)  89.51%   58.10%
MEM_FREE                               1005          59dc6000 (   1.404 GB)           35.10%
MEM_RESERVE                            1859          11667000 ( 278.402 MB)  10.47%    6.80%

--- Protect Summary (for commit) - RgnCount ----------- Total Size -------- %ofBusy %ofTotal
PAGE_READWRITE                         3406          4f8b3000 (   1.243 GB)  47.87%   31.07%
PAGE_READONLY                          2291          2b9c2000 ( 697.758 MB)  26.24%   17.04%
PAGE_EXECUTE_READ                       383          14726000 ( 327.148 MB)  12.30%    7.99%
PAGE_WRITECOPY                         1229           24fc000 (  36.984 MB)   1.39%    0.90%
PAGE_EXECUTE_READWRITE                  883           2417000 (  36.090 MB)   1.36%    0.88%
PAGE_EXECUTE_WRITECOPY                  324            4ef000 (   4.934 MB)   0.19%    0.12%
PAGE_READWRITE|PAGE_GUARD               166            391000 (   3.566 MB)   0.13%    0.09%
PAGE_NOACCESS                           149             95000 ( 596.000 kB)   0.02%    0.01%

--- Largest Region by Usage ----------- Base Address -------- Region Size ----------
Free                                        b7b20000          476b0000 (   1.116 GB)
<unknown>                                    3500000           1fff000 (  31.996 MB)
Image                                       22a62000           11e5000 (  17.895 MB)
MappedFile                                  a4fe0000           35de000 (  53.867 MB)
Heap                                        8ffe0000            f35000 (  15.207 MB)
Stack                                        3320000             f6000 ( 984.000 kB)
Other                                         bd0000             7f000 ( 508.000 kB)
TEB                                         ff1d2000              1000 (   4.000 kB)
PEB                                         ff465000              1000 (   4.000 kB)

after:

--- Usage Summary ---------------- RgnCount ----------- Total Size -------- %ofBusy %ofTotal
Heap                                   4770          5f6fb000 (   1.491 GB)  41.66%   37.28%
<unknown>                              2691          4a87d000 (   1.165 GB)  32.53%   29.11%
Image                                  7232          29a36000 ( 666.211 MB)  18.18%   16.27%
Free                                   1024          1ae86000 ( 430.523 MB)           10.51%
MappedFile                              142           cb4f000 ( 203.309 MB)   5.55%    4.96%
Stack                                   243           4b60000 (  75.375 MB)   2.06%    1.84%
Other                                     7             bc000 ( 752.000 kB)   0.02%    0.02%
TEB                                      80             50000 ( 320.000 kB)   0.01%    0.01%
PEB                                       1              1000 (   4.000 kB)   0.00%    0.00%

--- Type Summary (for busy) ------ RgnCount ----------- Total Size -------- %ofBusy %ofTotal
MEM_PRIVATE                            7739          ae3ac000 (   2.722 GB)  76.05%   68.06%
MEM_IMAGE                              7280          2a1b5000 ( 673.707 MB)  18.38%   16.45%
MEM_MAPPED                              147           cc09000 ( 204.035 MB)   5.57%    4.98%

--- State Summary ---------------- RgnCount ----------- Total Size -------- %ofBusy %ofTotal
MEM_COMMIT                            11036          83e02000 (   2.061 GB)  57.57%   51.51%
MEM_RESERVE                            4130          61368000 (   1.519 GB)  42.43%   37.97%
MEM_FREE                               1024          1ae86000 ( 430.523 MB)           10.51%

--- Protect Summary (for commit) - RgnCount ----------- Total Size -------- %ofBusy %ofTotal
PAGE_READWRITE                         5624          50744000 (   1.257 GB)  35.12%   31.43%
PAGE_READONLY                          2282          19c9a000 ( 412.602 MB)  11.26%   10.07%
PAGE_EXECUTE_READ                       384          147b7000 ( 327.715 MB)   8.94%    8.00%
PAGE_WRITECOPY                         1232           24f2000 (  36.945 MB)   1.01%    0.90%
PAGE_EXECUTE_READWRITE                  886           2444000 (  36.266 MB)   0.99%    0.89%
PAGE_EXECUTE_WRITECOPY                  324            4ef000 (   4.934 MB)   0.13%    0.12%
PAGE_READWRITE|PAGE_GUARD               176            3c8000 (   3.781 MB)   0.10%    0.09%
PAGE_NOACCESS                           128             80000 ( 512.000 kB)   0.01%    0.01%

--- Largest Region by Usage ----------- Base Address -------- Region Size ----------
Heap                                        8ffe0000            ec6000 (  14.773 MB)
<unknown>                                    3500000           1fff000 (  31.996 MB)
Image                                       22a62000           11e5000 (  17.895 MB)
Free                                        a4fe0000           35e0000 (  53.875 MB)
MappedFile                                  90fb0000           2e96000 (  46.586 MB)
Stack                                        3320000             f6000 ( 984.000 kB)
Other                                         bd0000             7f000 ( 508.000 kB)
TEB                                         ff1d2000              1000 (   4.000 kB)
PEB                                         ff465000              1000 (   4.000 kB)
@bwishan

This comment has been minimized.

bwishan commented Oct 7, 2017

@jcansdale Looks like the upgrade did the trick! Thanks for taking a look.
/cc @machish

@machish

This comment has been minimized.

machish commented Oct 9, 2017

@jcansdale , unfortunately, I can't even sign in with the new build. I see the login screen, and 'GitHubis underlined, but I can't click onGitHub Enterprise`. I tried it on two different machines (both VS2017, Win8.1) and unfortunately had the same results.

@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Oct 10, 2017

@machish Oh dear, it looks like you're having all the bad luck. Could you try following the steps and see if I can log in after that: #1242 (comment)

It's encouraging to hear the new build worked for @bwishan! Hopefully once you manage to log it, it will work for you as well. Keep me posted.

@machish

This comment has been minimized.

machish commented Oct 10, 2017

That workaround worked, and I was able to log in. (I had to restart VS for it to take effect).
I am also able to open a Pull Request and view the differences.
(There's still a lot of memory allocated, but it's harder to tell if it's devenv, Resharper, or the github plugin. :) )

Thanks!

@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Oct 11, 2017

@machish Thanks for the confirmation! It's true devenv and Resharper provide plenty of cover. 😉

We're working on a release that uses the latest stable version of LibGit2Sharp (v0.24):
#1248

Because this update cuts across pretty much all of our functionality, it will need lots of testing. We're hoping to get something out by the end of the week. I'll see if I can get a new build to you before then.

@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Oct 11, 2017

@machish I've added a link to the latest build here #1248 (comment)

If you could give that a try and confirm whether (on not) the "Failed to nmap..." issue is also fixed is this version, that would be very much appreciated. 🤞 You should be able to simply open the .vsix and it should update to the new version.

@machish

This comment has been minimized.

machish commented Oct 11, 2017

@jcansdale Yes, that build worked for both mmap and login issues. Thanks for the responsiveness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment