Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Open/Link to GitHub Available #1291

Closed
ambroselittle opened this Issue Nov 4, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@ambroselittle
Copy link

ambroselittle commented Nov 4, 2017

  • GitHub Extension for Visual Studio version: 2.3.4.54
  • Visual Studio version: 15.4.2

Repro:

  1. Open solution that is in a git repo from our GitHub Enterprise.
  2. Open any code (.cs) file (or .config, for instance).
  3. Right-click on any line to view the context menu.

Expected: See a GitHub -> menu that has an Open/Link to GitHub link that will take me to the corresponding line in the repo/branch that I'm on at the time.

Actual: No GitHub menu.

Notes: I reported this to Phil Haack and he looped in Andreia Gaita on Twitter. She suggested I report this here.

Will email logs.

@shana shana added the bug label Nov 7, 2017

@grokys

This comment has been minimized.

Copy link
Contributor

grokys commented Nov 9, 2017

Hi @ambroselittle,

Apologies for the delay. I've just tried this and indeed we seem to have a bug with Open/Link to GitHub on Enterprise instances.

The problem is at this line: repo.FullName returns the repo name in the form owner/name and it's being compared with ActiveRepo.Name which returns just the repro name.

Sorry about that - we'll get a fix in for the next release!

grokys added a commit that referenced this issue Nov 9, 2017

Correctly compare repository full name.
Fixes opening links on enterprise instances.

Previously we were comparing `repo.FullName == ActiveRepo.Name` which always failed as `repo.FullName` returns `owner/name` whereas `ActiveRepo.Name` just returns the `name` portion. Construct a full name for the active repo and check that.

Fixes #1291
@ambroselittle

This comment has been minimized.

Copy link
Author

ambroselittle commented Nov 9, 2017

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.