New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and hang/crash when opening PR detail #1293

Closed
shana opened this Issue Nov 6, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@shana
Collaborator

shana commented Nov 6, 2017

When opening #1283, got the following error message and then VS hung. Logged exception below.

image

2017-11-05 19:54:54.9714|ERROR|thread: 1|PullRequestDetailViewModel|Error loading PullRequestModel
LibGit2Sharp.NotFoundException: could not find 'docs/contributing/images/clone-dialog.png' to open: The system cannot find the path specified.

   at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
   at LibGit2Sharp.Core.Proxy.git_status_list_new(RepositoryHandle repo, GitStatusOptions options)
   at LibGit2Sharp.RepositoryStatus..ctor(Repository repo, StatusOptions options)
   at LibGit2Sharp.RepositoryExtensions.RetrieveStatus(IRepository repository)
   at GitHub.Services.PullRequestService.IsWorkingDirectoryClean(ILocalRepositoryModel repository) in C:\projects\visualstudio\src\GitHub.App\Services\PullRequestService.cs:line 91
   at GitHub.ViewModels.PullRequestDetailViewModel.<Load>d__100.MoveNext() in C:\projects\visualstudio\src\GitHub.App\ViewModels\PullRequestDetailViewModel.cs:line 439    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
   at LibGit2Sharp.Core.Proxy.git_status_list_new(RepositoryHandle repo, GitStatusOptions options)
   at LibGit2Sharp.RepositoryStatus..ctor(Repository repo, StatusOptions options)
   at LibGit2Sharp.RepositoryExtensions.RetrieveStatus(IRepository repository)
   at GitHub.Services.PullRequestService.IsWorkingDirectoryClean(ILocalRepositoryModel repository) in C:\projects\visualstudio\src\GitHub.App\Services\PullRequestService.cs:line 91
   at GitHub.ViewModels.PullRequestDetailViewModel.<Load>d__100.MoveNext() in C:\projects\visualstudio\src\GitHub.App\ViewModels\PullRequestDetailViewModel.cs:line 439

@shana shana added bug crash labels Nov 6, 2017

@meaghanlewis meaghanlewis added this to High Priority in BUGS Dec 2, 2017

@grokys

This comment has been minimized.

Contributor

grokys commented Dec 5, 2017

I think this should have been fixed by #1337. Just tested and I'm not seeing the error. Closing this out unless it crops up again.

@grokys grokys closed this Dec 5, 2017

BUGS automation moved this from High Priority to Done Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment