New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Enterprise Repo Links are always SSL #13

Closed
Jaben opened this Issue Jul 28, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@Jaben

Jaben commented Jul 28, 2015

First of all, thanks! Really liking the plugin so far!

But, one minor issue is our internal github enterprise install is not SSL and the repo in Visual Studio 2015 is http://, but the plugin converts all the links "Pull Request", "Pulse", "Graphs", "Issues" to https:// breaking the feature for us.

@Haacked

This comment has been minimized.

Show comment
Hide comment
@Haacked

Haacked Jul 28, 2015

Member

Ah! Yeah, we need to use the scheme of the Enterprise URL and not just hard-code it to https.

Member

Haacked commented Jul 28, 2015

Ah! Yeah, we need to use the scheme of the Enterprise URL and not just hard-code it to https.

@Haacked Haacked self-assigned this Jul 29, 2015

@Haacked

This comment has been minimized.

Show comment
Hide comment
@Haacked

Haacked Jul 29, 2015

Member

I'll fix this.

Member

Haacked commented Jul 29, 2015

I'll fix this.

@Jaben

This comment has been minimized.

Show comment
Hide comment
@Jaben

Jaben Jul 29, 2015

Awesome! Thanks Phil!

Jaben commented Jul 29, 2015

Awesome! Thanks Phil!

Haacked added a commit that referenced this issue Jul 30, 2015

Preserve HTTP scheme for enterprise repositories
Fixes #13

We need to preserve the format of the origin for non github.com
repositories (such as GitHub Enterprise instances). Many of them are not
set up with HTTPS because they're behind a firewall etc.

Haacked added a commit that referenced this issue Jul 30, 2015

Preserve HTTP scheme for enterprise repositories
Fixes #13

We need to preserve the format of the origin for non github.com
repositories (such as GitHub Enterprise instances). Many of them are not
set up with HTTPS because they're behind a firewall etc.

@Haacked Haacked added the bug label Jul 31, 2015

@shana shana closed this in #21 Aug 1, 2015

@shana shana modified the milestone: 1.0.12 Aug 13, 2015

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Aug 13, 2015

Collaborator

Fix released in v1.0.12.1 (website and VS gallery)

Collaborator

shana commented Aug 13, 2015

Fix released in v1.0.12.1 (website and VS gallery)

@fabriciogs

This comment has been minimized.

Show comment
Hide comment
@fabriciogs

fabriciogs Aug 14, 2015

Awesome! Thanks for this!

Awesome! Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment