New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User images not appearing next to viewed Pull Requests #1323

Closed
awbushnell opened this Issue Nov 15, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@awbushnell

awbushnell commented Nov 15, 2017

  • GitHub Extension for Visual Studio version: 2.3.5.277
  • Visual Studio version: Visual Studio Pro 2017 15.4.4

What happened (with steps, logs and screenshots, if possible):

I noticed that the "profile" images appearing next to all the pull requests I see from our repo only ever shows the default image and not what I can see when on GitHub and viewing pull requests in our browser. The attached screen shot is that I see in github in Visual studio for all my PR's for example, yet on GitHub I do have a profile image that does appear...

githubextensionimages

@meaghanlewis

This comment has been minimized.

Contributor

meaghanlewis commented Nov 16, 2017

Hi @awbushnell thanks for reporting this. I notice the missing user avatars as well while using an enterprise account. Do you also happen to be using GitHub Enterprise?

@meaghanlewis meaghanlewis added the bug label Nov 16, 2017

@awbushnell

This comment has been minimized.

awbushnell commented Nov 16, 2017

@meaghanlewis Yes, this is an Enterprise account. :-)

@grokys

This comment has been minimized.

Contributor

grokys commented Nov 23, 2017

This is happening on Enterprise because Enterprise doesn't seem to serve images over a Basic Auth connection for some reason. We'll need to get SSO working to fix this I think.

@meaghanlewis meaghanlewis added this to Low Priority in BUGS Dec 2, 2017

@grokys grokys self-assigned this Dec 11, 2017

@grokys

This comment has been minimized.

Contributor

grokys commented Dec 11, 2017

I've marked this issue as being fixed by #1373 as the best we can do is to allow the user to login to enterprise instances using SSO.

@meaghanlewis meaghanlewis moved this from Low Priority to In Progress in BUGS Dec 11, 2017

@grokys

This comment has been minimized.

Contributor

grokys commented Dec 20, 2017

Related issue for desktop: desktop/desktop#821

@sguthals

This comment has been minimized.

Contributor

sguthals commented Dec 30, 2017

Should we close this issue then?

@meaghanlewis

This comment has been minimized.

Contributor

meaghanlewis commented Jan 2, 2018

Yes, i believe we can close this issue @sguthals . It wil automatically be closed once #1373 is merged.

@shana shana closed this in #1373 Jan 25, 2018

BUGS automation moved this from In Progress to Done Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment