Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Details: Deleted file shouldn't show "Open ..." menu item #1348

Closed
shana opened this Issue Nov 28, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@shana
Copy link
Collaborator

shana commented Nov 28, 2017

If a file has been deleted in a PR and there are no local changes that add it back in some way, the context menu items related to opening that file in the solution don't do anything and should probably not be shown at all (or at least be disabled)

image

@shana shana added the bug label Nov 28, 2017

@meaghanlewis meaghanlewis added this to Low Priority in BUGS Dec 2, 2017

@meaghanlewis meaghanlewis moved this from Low Priority to Medium Priority in BUGS Dec 2, 2017

@grokys grokys self-assigned this Dec 11, 2017

@sguthals sguthals assigned sguthals and unassigned grokys Dec 12, 2017

@StanleyGoldman

This comment has been minimized.

Copy link
Contributor

StanleyGoldman commented Jan 11, 2018

I am not able to reproduce this bug.

img

@StanleyGoldman

This comment has been minimized.

Copy link
Contributor

StanleyGoldman commented Jan 11, 2018

@meaghanlewis could you confirm this for me?

@meaghanlewis

This comment has been minimized.

Copy link
Contributor

meaghanlewis commented Jan 11, 2018

@StanleyGoldman I just tried it out with Steven's SSO PR. When I am on master and just looking at the deleted files for the PR I see the same behavior as in the screenshot you shared.

When I actually check out the PR branch feature/sso I see what shana shows in the first screenshot and am able to Open File in Solution.

So, my question is if this bug was referring to being on the PR branch or not?

grokys added a commit that referenced this issue Aug 7, 2018

Don't allow "Open File in Solution" for deleted files.
When a PR is checked out and a deleted file is right-clicked on the changed files list, disable the "Open File in Solution" menu item as the file won't exist.

Fixes #1348

@grokys grokys moved this from Medium Priority to In Progress in BUGS Aug 7, 2018

@grokys grokys assigned grokys and unassigned sguthals Aug 7, 2018

BUGS automation moved this from In Progress to Done Aug 7, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 7, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.