Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pane fails to parse URLs for repositories with '.' in their name #1376

Closed
grokys opened this Issue Dec 12, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@grokys
Copy link
Contributor

grokys commented Dec 12, 2017

On current master, opening a PR in for example https://github.com/haf/DotNetZip.Semverd fails with:

System.NotSupportedException occurred
  HResult=-2146233067
  Message=Unrecognised GitHub pane URL: /haf/DotNetZip.Semverd/pull/104
  Source=GitHub.App
  StackTrace:
       at GitHub.ViewModels.GitHubPane.GitHubPaneViewModel.<NavigateTo>d__43.MoveNext() in D:\projects\VisualStudio\src\GitHub.App\ViewModels\GitHubPane\GitHubPaneViewModel.cs:line 253
  InnerException: 

This is because the pullUri regex doesn't accept periods in repository names.

@grokys grokys added the bug label Dec 12, 2017

@grokys grokys self-assigned this Dec 12, 2017

@grokys grokys added this to High Priority in BUGS Dec 12, 2017

grokys added a commit that referenced this issue Dec 12, 2017

Relax the GitHub pane URL regex.
Fix the GitHub pane URL regex that was causing #1376.

Although the actual regex for validating GitHub usernames and repository names are more complex than this, we're not actually _validating_ them, we just want to be able to parse them. The new regex, `[\w_.-]+` should encompass all valid usernames and repo names I think.

Fixes #1376

@grokys grokys moved this from High Priority to In Progress in BUGS Dec 12, 2017

@grokys grokys closed this in #1377 Dec 13, 2017

BUGS automation moved this from In Progress to Done Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.