New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRepository is sometimes set to null when changing PR branches #1421

Closed
jcansdale opened this Issue Jan 17, 2018 · 0 comments

Comments

Projects
1 participant
@jcansdale
Contributor

jcansdale commented Jan 17, 2018

  • GitHub Extension for Visual Studio version: v2.3.7.0
  • Visual Studio version: Visual Studio 2015 (14.0.25420.1)

You can see what's going on from the log:

2018-01-17 12:13:00.060 INFO [38] TeamExplorerContext       Refresh ActiveRepository: RepositoryPath=C:\Source\github.com\grokys\PullRequestSandbox, BranchName=comments-test, HeadSha=5affff80a92fcb44367df4a1e4244882105ecafa
2018-01-17 12:13:00.060 INFO [38] TeamExplorerContext       Fire PropertyChanged event for ActiveRepository
2018-01-17 12:14:44.513 INFO [09] TeamExplorerContext       Refresh ActiveRepository: RepositoryPath=C:\Source\github.com\grokys\PullRequestSandbox, BranchName=pr/34-possible-missing-comment, HeadSha=a16aa3a7b1288d4c02b7859f1d2de83c10f65b2e
2018-01-17 12:14:44.513 INFO [09] TeamExplorerContext       Fire StatusChanged event for ActiveRepository
2018-01-17 12:14:49.277 INFO [154] TeamExplorerContext       Refresh ActiveRepository: RepositoryPath=null, BranchName=null, HeadSha=null
2018-01-17 12:14:49.277 INFO [154] TeamExplorerContext       Fire PropertyChanged event for ActiveRepository
2018-01-17 12:14:50.306 EROR [01] PullRequestDetailViewModel Error loading pull request grokys/PullRequestSandbox/34 from GitHub
System.NullReferenceException: Object reference not set to an instance of an object.
   at GitHub.Services.PullRequestService.<>c__DisplayClass22_0.<<EnsureLocalBranchesAreMarkedAsPullRequests>b__0>d.MoveNext() in C:\source\github.com\github\VisualStudio\src\GitHub.App\Services\PullRequestService.cs:line 267
--- End of stack trace from previous location where exception was thrown ---
   at System.Reactive.PlatformServices.ExceptionServicesImpl.Rethrow(Exception exception)
   at System.Reactive.ExceptionHelpers.ThrowIfNotNull(Exception exception)
   at System.Reactive.Subjects.AsyncSubject`1.GetResult()
   at GitHub.InlineReviews.Services.PullRequestSessionManager.<GetSession>d__14.MoveNext() in C:\source\github.com\github\VisualStudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 148
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at GitHub.ViewModels.GitHubPane.PullRequestDetailViewModel.<Load>d__100.MoveNext() in C:\source\github.com\github\VisualStudio\src\GitHub.App\ViewModels\GitHubPane\PullRequestDetailViewModel.cs:line 344
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at GitHub.ViewModels.GitHubPane.PullRequestDetailViewModel.<Refresh>d__101.MoveNext() in C:\source\github.com\github\VisualStudio\src\GitHub.App\ViewModels\GitHubPane\PullRequestDetailViewModel.cs:line 448
2018-01-17 12:14:50.400 INFO [125] TeamExplorerContext       Refresh ActiveRepository: RepositoryPath=C:\Source\github.com\grokys\PullRequestSandbox, BranchName=pr/34-possible-missing-comment, HeadSha=a16aa3a7b1288d4c02b7859f1d2de83c10f65b2e
2018-01-17 12:14:50.400 INFO [125] TeamExplorerContext       Fire PropertyChanged event for ActiveRepository

@jcansdale jcansdale added the bug label Jan 17, 2018

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS Jan 24, 2018

@meaghanlewis meaghanlewis moved this from Medium Priority to In Progress in BUGS Jan 24, 2018

@grokys grokys added this to In progress in 2.4.0 Jan 26, 2018

@grokys grokys closed this in #1422 Jan 29, 2018

BUGS automation moved this from In Progress to Done Jan 29, 2018

2.4.0 automation moved this from In progress to Done Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment