New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes inline comments have no associated diff lines #1435

Closed
jcansdale opened this Issue Jan 30, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jcansdale
Contributor

jcansdale commented Jan 30, 2018

  • GitHub Extension for Visual Studio version: 2.4.0 (dev)
  • Visual Studio version: 2015

What happened (with steps, logs and screenshots, if possible)

An exception was thrown on this line:

public DiffChangeType DiffLineType => DiffMatch.First().Type;

This is the inline comment that has no diff line context: grokys/PullRequestSandbox#24 (review)

    Body: "comment on main"
    CommitId: "080d67f93efeb557f8bb24a009effb85bde353aa"
    CreatedAt: {01/06/2017 13:55:49 +00:00}
    DiffHunk: "@@ -10,7 +10,6 @@ class Program"
    Id: 119620146
    OriginalCommitId: "b328e39e53c85ea15208a60c7af74698d3e146d2"
    OriginalPosition: 6
    Path: "PullRequestSandbox/Program.cs"
    Position: 0
    User: Account: Login: jcansdale IsUser: True

@jcansdale jcansdale added the bug label Jan 30, 2018

@jcansdale jcansdale self-assigned this Jan 30, 2018

@meaghanlewis meaghanlewis added this to In Progress in BUGS Jan 30, 2018

@grokys grokys closed this in #1439 Jan 31, 2018

BUGS automation moved this from In Progress to Done Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment