New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting NavigationViewModel.History throws exception #1436

Closed
grokys opened this Issue Jan 30, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@grokys
Contributor

grokys commented Jan 30, 2018

NavigationViewModel.History is a ReactiveList with a CollectionChanged handler that doesn't support NotifyCollectionChangedAction.Reset.

This is a problem because when the history is cleared (by e.g. moving to a new repository), if the history has >10 items a reset will occur, causing the GitHub pane to hang with a spinner until a new project is loaded,

@grokys grokys added the bug label Jan 30, 2018

@grokys grokys self-assigned this Jan 30, 2018

grokys added a commit that referenced this issue Jan 30, 2018

grokys added a commit that referenced this issue Jan 30, 2018

Fixed #1436.
We need to handle `Reset` collection events on the `Changing` handler so that we can get to the items before they're removed from the collection and `Dispose` them.

@meaghanlewis meaghanlewis added this to In Progress in BUGS Jan 30, 2018

BUGS automation moved this from In Progress to Done Jan 31, 2018

@meaghanlewis meaghanlewis changed the title from Resetting NavigationViewModel.History throws. to Resetting NavigationViewModel.History throws exception Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment