New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompted for "token" when signing into GitHub enterprise... #1474

Closed
awbushnell opened this Issue Feb 8, 2018 · 10 comments

Comments

Projects
5 participants
@awbushnell

awbushnell commented Feb 8, 2018

  • GitHub Extension for Visual Studio version: 2.4.1.1219
  • Visual Studio version: Microsoft Visual Studio Professional 2017 Version 15.5.5

What happened (with steps, logs and screenshots, if possible):

When trying to log into our Enterprise server, upon entering our sever, and it correctly identifying it, I get prompted for a personal access token, instead of my username/password as I am typically prompted for to access our server.... See screenshot:

capture

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

Thanks for opening this @awbushnell - could you tell me what version of GitHub Enterprise you're on?

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

If you're needing to login in the meantime, we're in the process of adding instructions for creating a token here: https://github.com/github/VisualStudio/blob/abff93d8c387c34e18b0fc5e3097893c2719f474/docs/getting-started/authenticating-to-github.md#authenticating-to-github

@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

@grokys We are currently on version 2.11.6 but "soonish" will be moving to 2.12

@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

@grokys I managed to generate a token and am logged in now. thanks

@shana

This comment has been minimized.

Collaborator

shana commented Feb 8, 2018

@awbushnell Just to confirm, you used to login with just username/password before and now it's always asking for a token, correct?

@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

@shana Yes that is correct, I do not ever recall getting prompted for a token.

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

Yes, I think this should be considered a bug. We're querying the server metadata to see if it accepts a username and password. If it doesn't accept a username and password we prompt for a token.

The bug comes about because enterprise instances <2.12 don't actually return that metadata, in which case we assume that the server doesn't accept a username and password. We should instead assume it does.

@grokys grokys added this to To do in 2.4.3 Feb 8, 2018

@DaleGardner

This comment has been minimized.

DaleGardner commented Feb 12, 2018

I just encountered the same issue. As it happens, our enterprise is updating to 2.12.4 tomorrow. Planning to try logging in then and see if it works. :)

grokys added a commit that referenced this issue Feb 15, 2018

Assume enterprise user/pass login available.
If the enterprise server doesn't return a value for `VerifiablePasswordAuthentication`, or the `api/meta` endpoint fails completely then we're on an older version of enterprise. In this case assume username and password login is available as we have no way to tell.

Fixes #1474

@grokys grokys moved this from To do to In progress in 2.4.3 Feb 15, 2018

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 15, 2018

Hi @awbushnell - if you have a moment could you try the vsix here and see if it fixes your login problem?

I'd advise switching back to the stable vsix once you've tested, as this version has not been through our testing process.

@awbushnell

This comment has been minimized.

awbushnell commented Feb 15, 2018

@grokys Thank you, I gave that a try, and yes that worked, prompted me for username and password and token as expected with our current enterprise server/version etc..

@meaghanlewis meaghanlewis added the bug label Feb 15, 2018

@meaghanlewis meaghanlewis added this to In Progress in BUGS Feb 15, 2018

@shana shana closed this in #1487 Feb 21, 2018

BUGS automation moved this from In Progress to Done Feb 21, 2018

2.4.3 automation moved this from In progress to Done Feb 21, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment