Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text "Pull request" from PR button on status bar #1621

Closed
justcla opened this Issue Apr 21, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@justcla
Copy link

justcla commented Apr 21, 2018

  • GitHub Extension for Visual Studio version: 2.5.1.2234
  • Visual Studio version: 15.7.0 Preview 5.0 (27619.1.d15.7)

PR #1519 introduced text on the status bar that reads "Pull requests".

The text on this button is very distracting. So much so, I had to disable the GitHub extension in Visual Studio.

It draws my attention, when my attention should not go to it
It was very effective at drawing my attention to it, but I did not need it at the time. I had just opened a clean project on master branch and had no changes or commits, no previous PRs and no other contributors to tat project. I can see it being useful later on - particularly when I have commits worth pushing and a branch to merge. But until then, and even after then, the text "Pull requests" is very distracting.

It's not consistent with similar/neighboring icons
There is no text on the commit and push icons (to the right of the Pull request button), and by the nature of commits, branches and PRs, they would be used more often - and yet they don't take up space with distracting text.

Once you know what the button is, you don't need the text to tell you
The tooltip is effective, if a user bothers to hover over it.
Alternatively, you could try advertising it with some point-in-time notification/spotlight. (Though, I don't know how you would achieve that.)

Can I politely ask that you remove the "Pull request" text from the status bar button?

Then I can turn my GitHub extension back on again.

Thanks! :-D

@justcla justcla changed the title Remove text from "Pull request" button on status bar Remove text "Pull request" from PR button on status bar Apr 21, 2018

@jcansdale

This comment has been minimized.

Copy link
Collaborator

jcansdale commented Apr 23, 2018

Can I politely ask that you remove the "Pull request" text from the status bar button?
Then I can turn my GitHub extension back on again.

I've created a very quick spike PR for you here #1622. Here's the .vsix artifact:
https://ci.appveyor.com/api/buildjobs/3bx4bobpobc8apdx/artifacts/2.5.1.2270%2FGitHub.VisualStudio.vsix

This is just so you can turn it back on. 😉 I'll discuss the rest of your feedback with the team.

@justcla

This comment has been minimized.

Copy link
Author

justcla commented Apr 25, 2018

This is great. Thanks. Solves my immediate problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.