New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request summary Cancel button needs confirmation #1653

Closed
StanleyGoldman opened this Issue May 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@StanleyGoldman
Contributor

StanleyGoldman commented May 9, 2018

The Cancel button noted here will remove all of a user's in progress review comments.
The user may not be aware of the effect and may simply be trying to leave the screen because they are not ready to complete their review.

The effect of the cancel button should be clearly explained with a dialog/confirmation before allowing the user to continue.

image

@StanleyGoldman StanleyGoldman added the bug label May 9, 2018

@StanleyGoldman StanleyGoldman self-assigned this May 9, 2018

@meaghanlewis meaghanlewis added this to Low Priority in BUGS May 29, 2018

@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Jun 14, 2018

Contributor

On dotcom, there is a confirmation for the Cancel review option explaining that all pending comments will be lost and this is really helpful.

confirm cancel

Contributor

meaghanlewis commented Jun 14, 2018

On dotcom, there is a confirmation for the Cancel review option explaining that all pending comments will be lost and this is really helpful.

confirm cancel

@meaghanlewis meaghanlewis moved this from Low Priority to In Progress in BUGS Aug 6, 2018

@meaghanlewis meaghanlewis moved this from In Progress to Low Priority in BUGS Aug 6, 2018

@meaghanlewis meaghanlewis moved this from Low Priority to In Progress in BUGS Aug 7, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 8, 2018

BUGS automation moved this from In Progress to Done Aug 9, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment