New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling is broken in PRs with lots of changed files. #1698

Closed
grokys opened this Issue May 21, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented May 21, 2018

When looking at the details for a large PR, the horizontal scroll bar is shown at the bottom of the scrollable area, meaning that one has to scroll right to the bottom in order to scroll horizontally. This makes navigating this panel very difficult:

2018-05-21_10-06-49

@grokys grokys added the usability label May 21, 2018

@grokys grokys self-assigned this May 21, 2018

grokys added a commit that referenced this issue May 21, 2018

Fix scrolling in PR details view.
Added a `ScollingVerticalStackPanel` which can be used to mark controls as "fixed" meaning they don't scroll horizontally. Mark all controls in the PR details as fixed except the changes tree.

Fixes #1698

@meaghanlewis meaghanlewis added this to the 2.5.3 milestone May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment