Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request review does not show when a review is dismissed #1715

Closed
meaghanlewis opened this Issue Jun 1, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@meaghanlewis
Copy link
Contributor

meaghanlewis commented Jun 1, 2018

What happened

Steps to reproduce:

  1. Create a pull request or use an existing one
  2. Leave a reivew
  3. Dismiss a review on dotcom
  4. From Visual Studio, go back to the pull request and refresh

image 3

What happens:

  • The initial review still shows
  • Clicking on the reviewer name does not show the most recent review was dismissed

What should actually happen:

  • The view should show the review as a comment review
  • Clicking on the reviewer name should show that the most recent review was dismissed

@meaghanlewis meaghanlewis added the bug label Jun 1, 2018

@meaghanlewis meaghanlewis changed the title Pull review does not show when a review is dismissed Pull Request review does not show when a review is dismissed Jun 1, 2018

@meaghanlewis meaghanlewis added this to Low Priority in BUGS Jun 18, 2018

@StanleyGoldman StanleyGoldman self-assigned this Aug 7, 2018

BUGS automation moved this from Low Priority to Done Aug 7, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 7, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.