Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolling PR changes horizontally, the UI is cut off on the left #1738

Closed
Neme12 opened this Issue Jun 15, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Neme12
Copy link
Contributor

Neme12 commented Jun 15, 2018

image

This can also be seen here in the pictures: #1699

Notice that there's about 8px horizontally on the left outside of the scroll viewer, which results in the content inside being cut off into whitespace when scrolling horizontally. This margin/padding should be inside the scroll viewer, not outside. That will also make the scrollbar full width.

@Neme12 Neme12 changed the title When scrolling PR changes horizontally When scrolling PR changes horizontally, the UI is cut off on the left Jun 15, 2018

grokys added a commit that referenced this issue Jun 18, 2018

Tidy up PR details XAML.
When coming to fix #1738, I noticed that the XAML in the PR details view had got quite messy, with quite a few unneeded `Grid`s and other layout controls.

Simplified the XAML a bit and fixed #1738.

@meaghanlewis meaghanlewis added the bug label Jun 18, 2018

@meaghanlewis meaghanlewis added this to the 2.5.4 milestone Jun 18, 2018

@meaghanlewis meaghanlewis added this to In Progress in BUGS Jun 18, 2018

BUGS automation moved this from In Progress to Done Jun 20, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.