New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository creation failed with control characters in description #1777

Closed
jcansdale opened this Issue Jul 11, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@jcansdale
Contributor

jcansdale commented Jul 11, 2018

  • GitHub Extension for Visual Studio version: 2.5.4
  • Visual Studio version: 2017

image

Looking at fiddler, it appears there are some restrictions in what chars are allowed in the description:

image

What I expected to happen

Maybe it should show the error message?

message=description control characters are not allowed
@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Jul 12, 2018

Contributor

Nice find @jcansdale. The message description control characters are not allowed is still a bit vague because it's not clear which character isn't allowed but I think it's better than a general repository creation failure.

Also, I tried the same description when creating a repository on dotcom and it was able to be created just fine. I'm wondering why the control characters are allowed there but not in Visual Studio.

Contributor

meaghanlewis commented Jul 12, 2018

Nice find @jcansdale. The message description control characters are not allowed is still a bit vague because it's not clear which character isn't allowed but I think it's better than a general repository creation failure.

Also, I tried the same description when creating a repository on dotcom and it was able to be created just fine. I'm wondering why the control characters are allowed there but not in Visual Studio.

@meaghanlewis meaghanlewis added the bug label Jul 16, 2018

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS Aug 6, 2018

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 8, 2018

Contributor

@jcansdale any idea what the control characters were in the description? I can't see any in the fiddler screenshot that you posted.

Contributor

grokys commented Aug 8, 2018

@jcansdale any idea what the control characters were in the description? I can't see any in the fiddler screenshot that you posted.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 8, 2018

Contributor

Also, I tried the same description when creating a repository on dotcom and it was able to be created just fine. I'm wondering why the control characters are allowed there but not in Visual Studio.

I suspect .com may just be stripping control characters? Assuming that's the case, it would make sense for us to do the same.

Contributor

grokys commented Aug 8, 2018

Also, I tried the same description when creating a repository on dotcom and it was able to be created just fine. I'm wondering why the control characters are allowed there but not in Visual Studio.

I suspect .com may just be stripping control characters? Assuming that's the case, it would make sense for us to do the same.

@grokys grokys changed the title from Repository creation failed to Repository creation failed with control characters in description Aug 8, 2018

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 8, 2018

Contributor

I think the control char in question might be \r. 😆

Contributor

jcansdale commented Aug 8, 2018

I think the control char in question might be \r. 😆

@jcansdale jcansdale self-assigned this Aug 8, 2018

@jcansdale jcansdale moved this from Medium Priority to In Progress in BUGS Aug 8, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 8, 2018

@grokys grokys closed this in #1845 Aug 10, 2018

BUGS automation moved this from In Progress to Done Aug 10, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment