New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete comment icon is very close to close window icon #1797

Closed
jcansdale opened this Issue Jul 24, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@jcansdale
Contributor

jcansdale commented Jul 24, 2018

  • GitHub Extension for Visual Studio version: 2.5.4

The ✖️ icon to delete an inline-comment is very close to the icon used to close the inline-comment window and also appears in the top right hand corner of a box.
image

If a user accidentally clicks on the delete icon, there is no confirmation to correct their mistake.

Maybe we could change it to be a ... drop down menu with a Delete option like .com relatively recently changed to.

image

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Jul 24, 2018

Contributor

Related to #1713

Contributor

StanleyGoldman commented Jul 24, 2018

Related to #1713

@donokuda

This comment has been minimized.

Show comment
Hide comment
@donokuda

donokuda Jul 31, 2018

Member

I'm going to take a quick stab at this and #1713.

I'll focus on two things:

  1. Increasing the spacing between the ✏️ and the octicon
  2. Popup a dialog when a user clicks on the asking them to confirm if they want to delete the comment. (and clicking "Delete" should delete the comment.)

EDIT: Side goal, regardless if my pull request is merged or not, is that I want to learn how to implement a modal dialog. I think there are places in the extension where we could utilize this pattern.

Member

donokuda commented Jul 31, 2018

I'm going to take a quick stab at this and #1713.

I'll focus on two things:

  1. Increasing the spacing between the ✏️ and the octicon
  2. Popup a dialog when a user clicks on the asking them to confirm if they want to delete the comment. (and clicking "Delete" should delete the comment.)

EDIT: Side goal, regardless if my pull request is merged or not, is that I want to learn how to implement a modal dialog. I think there are places in the extension where we could utilize this pattern.

@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Aug 6, 2018

Contributor

I think we can close this out now. Please re-open if I'm incorrect 😄

Contributor

meaghanlewis commented Aug 6, 2018

I think we can close this out now. Please re-open if I'm incorrect 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment