Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for Pull Request too soon can freeze Visual Studio #1828

Closed
StanleyGoldman opened this Issue Aug 3, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Aug 3, 2018

  1. Goto pull request view
  2. Switch to display Closed Issues
  3. Quickly type in an issue number and push enter before list loads

2018-08-03_17-03-42

2018-08-03_17-06-56

@StanleyGoldman StanleyGoldman added the bug label Aug 3, 2018

@meaghanlewis meaghanlewis added this to High Priority in BUGS Aug 6, 2018

@grokys grokys moved this from High Priority to In Progress in BUGS Aug 7, 2018

@grokys grokys self-assigned this Aug 7, 2018

grokys added a commit that referenced this issue Aug 7, 2018

Only update PR list state on main thread.
`IVirtualizingListSource.IsLoading` can be signalled on a background thread. This was causing a deadlock in #1828. Make sure we call `IssueListViewModelBase.UpdateState` on the UI thread.

Fixes #1828

BUGS automation moved this from In Progress to Done Aug 7, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 7, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.