New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA dialog stays busy when network connection is down #19

Closed
shana opened this Issue Jul 29, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@shana
Collaborator

shana commented Jul 29, 2015

Imported from github/VisualStudioInternal#346

Repro steps:

  1. Login with an account that has 2fa enabled.
  2. Disconnect internet access from your computer.
  3. Enter 2fa code and hit verify.

Expected: 2fa dialog shows an error message.
Actual: The verify button stays disabled and busy. Note, the dialog is still responsive, the operation just never completes.

@shana shana added the bug label Jul 29, 2015

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Jul 29, 2015

Collaborator

Not sure if this one is actually valid any more, it's from April 25. Needs testing.

Collaborator

shana commented Jul 29, 2015

Not sure if this one is actually valid any more, it's from April 25. Needs testing.

@JoshDobbin

This comment has been minimized.

Show comment
Hide comment
@JoshDobbin

JoshDobbin Jul 12, 2016

I'm also running into the same issue as of the latest version (1.0.18.6).

I'm also running into the same issue as of the latest version (1.0.18.6).

@brezho

This comment has been minimized.

Show comment
Hide comment
@brezho

brezho Aug 24, 2016

Same here with 2.0.14.4

brezho commented Aug 24, 2016

Same here with 2.0.14.4

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 6, 2017

Contributor

I think this is the same issue as #829 - the 2FA dialog doesn't catch any non-2FA exception and just sits there spinning.

Contributor

grokys commented Feb 6, 2017

I think this is the same issue as #829 - the 2FA dialog doesn't catch any non-2FA exception and just sits there spinning.

@grokys grokys referenced this issue Feb 6, 2017

Open

Refactor login process #809

3 of 6 tasks complete

grokys added a commit that referenced this issue Feb 9, 2017

Handle errors in 2FA flow.
Handle non 2FA-errors in the 2FA flow. When such an error occurs, the
user is taken back to the username/password view and an error message is
shown. Fixes #829. Fixes #19.

@grokys grokys closed this in #845 Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment