New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not load file or assembly 'Newtonsoft.Json, Version=9.0.0.0' #1969

Closed
efev0f0 opened this Issue Oct 3, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@efev0f0

efev0f0 commented Oct 3, 2018

Using 2.5.6.4958, when trying to clone a repo, this exception is thrown. Thanks!

2018-10-03 16:17:54.949 [10996] EROR [01] RepositorySelectViewModel Error reading repository list from GitHub.Primitives.HostAddress
System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified.
File name: 'Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
at Octokit.GraphQL.Core.Builders.QueryBuilder.Build[TResult](IQueryableValue1 query) at Octokit.GraphQL.QueryableValueExtensions.Compile[T](IQueryableValue1 expression)
at GitHub.Services.RepositoryCloneService.d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.ViewModels.Dialog.Clone.RepositorySelectViewModel.d__37.MoveNext()

@mylle

This comment has been minimized.

Show comment
Hide comment
@mylle

mylle Oct 4, 2018

Same problem when opening the 'GitHub' View to to a pull request.
Any solutions?
image

mylle commented Oct 4, 2018

Same problem when opening the 'GitHub' View to to a pull request.
Any solutions?
image

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 4, 2018

Contributor

Hmm, looks like this may be #1774 manifesting itself. Strange that it's showing up now though as we've been shipping that version for the last 8 months...

Will investigate further and get a bug release out asap.

Contributor

grokys commented Oct 4, 2018

Hmm, looks like this may be #1774 manifesting itself. Strange that it's showing up now though as we've been shipping that version for the last 8 months...

Will investigate further and get a bug release out asap.

@mylle

This comment has been minimized.

Show comment
Hide comment
@mylle

mylle Oct 5, 2018

Do I need to update the extension? If so, how?

mylle commented Oct 5, 2018

Do I need to update the extension? If so, how?

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 5, 2018

Contributor

@efev0f0 @mylle firstly, could you let me know which version of Visual Studio you're on?

Secondly, I've opened a PR that might fix this: #1975

Could you give that a try? You can download the artifacts from https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.6.5015/artifacts - download GitHub.VisualStudio.vsix and run it.

Contributor

grokys commented Oct 5, 2018

@efev0f0 @mylle firstly, could you let me know which version of Visual Studio you're on?

Secondly, I've opened a PR that might fix this: #1975

Could you give that a try? You can download the artifacts from https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.6.5015/artifacts - download GitHub.VisualStudio.vsix and run it.

@mylle

This comment has been minimized.

Show comment
Hide comment
@mylle

mylle Oct 5, 2018

Visual Studio 2015: Version 14.0.25431.01 Update 3
GitHub.VisualStudio: 2.5.6.4958

Update did not fix the problem

mylle commented Oct 5, 2018

Visual Studio 2015: Version 14.0.25431.01 Update 3
GitHub.VisualStudio: 2.5.6.4958

Update did not fix the problem

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 5, 2018

Contributor

Yes, if you're on 2015 then that won't fix the problem - neither of you mentioned the version of VS you were using so I assumed 2017.

We're investigating 2015 now.

Contributor

grokys commented Oct 5, 2018

Yes, if you're on 2015 then that won't fix the problem - neither of you mentioned the version of VS you were using so I assumed 2017.

We're investigating 2015 now.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 5, 2018

Contributor

@mylle ok, hopefully we've got it this time: could you try the version here: https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.6.5020/artifacts

Contributor

grokys commented Oct 5, 2018

@mylle ok, hopefully we've got it this time: could you try the version here: https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.6.5020/artifacts

@efev0f0

This comment has been minimized.

Show comment
Hide comment
@efev0f0

efev0f0 Oct 5, 2018

@grokys it worked for me, thanks!

efev0f0 commented Oct 5, 2018

@grokys it worked for me, thanks!

@efev0f0 efev0f0 closed this Oct 5, 2018

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Oct 6, 2018

Contributor

Thanks for reporting this. The issue will be automatically closed by #1975.

Contributor

jcansdale commented Oct 6, 2018

Thanks for reporting this. The issue will be automatically closed by #1975.

@jcansdale jcansdale reopened this Oct 6, 2018

@mylle

This comment has been minimized.

Show comment
Hide comment
@mylle

mylle Oct 8, 2018

@grokys , this fixed my problem!
Thank you!

mylle commented Oct 8, 2018

@grokys , this fixed my problem!
Thank you!

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 8, 2018

Contributor

Fixed in 2.5.7.5090 - the release should roll out to all users shortly!

Thanks for helping us test @efev0f0 @mylle, and sorry for the inconvenience.

Contributor

grokys commented Oct 8, 2018

Fixed in 2.5.7.5090 - the release should roll out to all users shortly!

Thanks for helping us test @efev0f0 @mylle, and sorry for the inconvenience.

@grokys grokys closed this Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment