New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens when I click `Create pull request` on public repository #2058

Closed
jcansdale opened this Issue Nov 16, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@jcansdale
Copy link
Collaborator

jcansdale commented Nov 16, 2018

Version

  • GitHub Extension for Visual Studio version: v2.5.9.5485
  • Visual Studio version: All

What happened

Steps to Reproduce

  1. Clone a public repository (update: that isn't one of yours or your organization's)
  2. Create a branch and make some commits
  3. Click Create button on GitHub pane
  4. Enter pull request title/description and click Create pull request

Expected behavior:

  • Minimum: Show an error
  • Better: Let user know how to fork and create a pull request
  • Best: Automatically fork and create a pull request

Actual behavior:

Nothing happens when Create pull request is clicked.

Screenshot or GIF:

image

Related

  • Partial fix - #2173: Fix displaying errors in GitHub pane.

@meaghanlewis meaghanlewis added the bug label Nov 16, 2018

@PriyadharsiniJ

This comment has been minimized.

Copy link

PriyadharsiniJ commented Nov 19, 2018

Facing the same issue, any update or resolution available?

@jcansdale

This comment has been minimized.

Copy link
Collaborator Author

jcansdale commented Nov 19, 2018

@PriyadharsiniJ,

For the moment I'd recommend doing the following:

  1. Enable Show Fork button in Team Explorer
    image
  2. Fork the repository
    image
  3. Create pull request
    image

I like to do this as well:

  1. From the command line do the following
git remote rename origin your_user_name
git remote rename upstream origin
  1. View the pull request list on the GitHub pane

You should now see a pull request from your GitHub account to the public repository you originally cloned.

I'd love for all this to be completely automated!

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS Dec 7, 2018

@jcansdale jcansdale closed this in c53fa14 Jan 11, 2019

BUGS automation moved this from Medium Priority to Done Jan 11, 2019

@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 11, 2019

@meaghanlewis meaghanlewis removed this from Done in BUGS Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment