Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add or reply to comments #2144

Closed
parvezapathan opened this issue Dec 19, 2018 · 1 comment

Comments

@parvezapathan
Copy link

commented Dec 19, 2018

image

@jcansdale

This comment has been minimized.

Copy link
Collaborator

commented Dec 19, 2018

👋 @parvezapathan,

Thanks for the report. This is an annoying issue and I'm working on a fix!

The problem is that the diffing algorithm that the extension uses is slightly different to the one used on github.com. This can cause line number mismatches, hidden comments and situations where comments can't be submitted.

Here is a related issue and a WIP PR:

  • #1469 Inline comment appears on PR page but not in GitHub extension
  • #2142 Update to use modern version of LibGit2Sharp and use indent heuristic when diffing

@meaghanlewis meaghanlewis added the bug label Dec 19, 2018

@StanleyGoldman StanleyGoldman changed the title Unable to add reply to comments GitHub Enterprise over http unable to add or reply to comments Apr 11, 2019

@StanleyGoldman StanleyGoldman changed the title GitHub Enterprise over http unable to add or reply to comments Unable to add or reply to comments Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.