New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't leave comment on deleted line #2166

Closed
jcansdale opened this Issue Jan 9, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@jcansdale
Copy link
Collaborator

jcansdale commented Jan 9, 2019

Versions

  • GitHub Extension for Visual Studio version: 2.7.0 (dev)
  • Visual Studio version: 2017

What happened

  1. I tried to leave a comment on the deleted line 134 of RepositoryCreationViewModel.cs PR #2165
  2. The inline comment UI appears but is empty

image

Expected behavior

Expected inline comment box to appear like it does on the RHS.

image

grokys added a commit that referenced this issue Jan 9, 2019

Fix AvailableForComment calculation.
When showing a comment peek view on the LHS of the diff view, we need to look at `OldLineNumber` instead of `NewLineNumber` to calculate `AvailableForComment`.

Fixes #2166

@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 11, 2019

@jcansdale jcansdale added the bug label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment