New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error shown when creating a PR fails #2172

Closed
grokys opened this Issue Jan 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@grokys
Copy link
Collaborator

grokys commented Jan 10, 2019

Versions

  • GitHub Extension for Visual Studio version: >=2.6.1
  • Visual Studio version: All

What happened

When creating a PR fails, no error message is shown.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create a branch with no commits
  2. Click "Create New" on the PR list
  3. Enter a title/description and click "Create pull request"
  4. PR creation fails but no error is shown.

Expected behavior

An error should be shown in the GitHub pane.

Related

  • #2058: Nothing happens when I click Create pull request on public repository

@grokys grokys added the bug label Jan 10, 2019

grokys added a commit that referenced this issue Jan 10, 2019

Fix displaying errors in GitHub pane.
#1787 refactored `InfoPanel` but didn't update `GitHubPaneView` with its new behavior. So:

- Don't initialy set `infoPanel.Visibility` to `Collapsed`: `InfoPanel` will handle this itself
- Set `ShowCloseButton` to show the `x` button to close the error

Fixes #2172
Fixes #2058

@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 11, 2019

@jcansdale jcansdale changed the title No error shown when creating PR fails No error shown when creating a PR fails Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment