Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone from VS 2019 Clone dialog doesnt work on First Launch #2218

Closed
prasethu opened this issue Feb 5, 2019 · 2 comments

Comments

@prasethu
Copy link
Collaborator

commented Feb 5, 2019

Install the github extension with the changes related to cloning from Get To Code

Attempt to clone on the very first launch.

Notice that the GitHub dialog dismisses and Get To Code remains visible and no repo is cloned.

@prasethu

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 5, 2019

@jcansdale

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

Damn, well this is a fun bug. 😉

I think the issue is that when Visual Studio is launched for the very first time, no source control plug-in has been set. The current source control plug-in will automatically change to Git when a solution is opened from a Git repository.

We can repo this by changing the current source control plug-in to None:
image

Relaunch Visual Studio and attempt to clone a repository using Clone or check out code > GitHub > Clone. The following will appear in the log:

2019-02-06 09:47:47.720 [12532] EROR [01] RepositoryCloneService    Could not clone https://github.com/jcansdale/bin to C:\Source\github.com\jcansdale\bin
System.InvalidOperationException: Could not locate any instances of contract Microsoft.VisualStudio.TeamFoundation.Git.Extensibility.IGitActionsExt.
   at GitHub.VisualStudio.GitHubServiceProvider.GetService(Type serviceType) in C:\Source\github.com\github\VisualStudio\src\GitHub.VisualStudio\Services\GitHubServiceProvider.cs:line 147
   at GitHub.VisualStudio.GitHubServiceProvider.GetService[T]() in C:\Source\github.com\github\VisualStudio\src\GitHub.VisualStudio\Services\GitHubServiceProvider.cs:line 153
   at GitHub.Services.VSGitServices.<Clone>d__7.MoveNext() in C:\Source\github.com\github\VisualStudio\src\GitHub.TeamFoundation.14\Services\VSGitServices.cs:line 92
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at GitHub.Services.RepositoryCloneService.<CloneRepository>d__14.MoveNext() in C:\Source\github.com\github\VisualStudio\src\GitHub.App\Services\RepositoryCloneService.cs:line 215

I'll start working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.