Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Enterprise over http unable to adding review comment #2224

Closed
pmunin opened this issue Feb 12, 2019 · 7 comments

Comments

@pmunin
Copy link

commented Feb 12, 2019

Versions

  • GitHub Extension for Visual Studio version: 2.7.1.6591
  • Visual Studio version: 2017 Pro

What happened

I have github for enterprise intranet server deployed. There server only supports http connection (HTTP://github.{mycompany}.com). When works fine, until I try to add a comment for PR, it shows "An error occurred while sending the request". In Fiddler I can see, that it tries to send requests to HTTPS:443 tunnel, even though all other requests work fine and go through HTTP:80, including showing list of available PRs and shows existing comments fine.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Add local Github for Enterprise deployed to local HTTP (not HTTPs) server
  2. Open some active PR for review in Visual Studio
  3. Try to add new review comment for the PR
  4. See error "An error occurred while sending the request"

Expected behavior

Successfully add request

Screenshots

image

image

@jcansdale

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Hi @pmunin,

Sorry about the delay getting back to you!

I've been doing some investigation as it isn't obvious why it would be doing this. We should be preserving the HTTP or HTTPS protocol of the host.

Could you try using the File > Open > Open from GitHub... command and let me know if the repository list appears for your Enterprise server? This uses GraphQL just like the API for posting a comment.

@jcansdale jcansdale added the bug label Mar 25, 2019

@jcansdale jcansdale self-assigned this Mar 25, 2019

@pmunin

This comment has been minimized.

Copy link
Author

commented Mar 25, 2019

Just tried your advice, opened/cloned github repo from file/Open menu - same story, opens PR, and shows changes, but fails to add any comments to it. Just try this action on a local github server where HTTPS is unavailable (only HTTP)

@jcansdale

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

Thanks for letting me know. This is strange because the open/clone dialog uses GitHub v4/GraphQL API. I thought initially that the GitHub v4/GraphQL API might always be using HTTPS.

I'm wondering if the issue might be the version of GitHub Enterprise you're using rather than HTTPS? Do you know which version you have installed?

@pmunin

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

It says Enterprise Server 2.13, when I open github/help

@StanleyGoldman StanleyGoldman self-assigned this Mar 28, 2019

@StanleyGoldman

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

I am able to reproduce this issue using Enterprise 2.1.3 over http.

@jcansdale

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

Hi @pmunin,

We're hoping this issue is fixed in #2305.

Could you try installing the VSIX from the following location and let me know if that resolves the issue
https://ci.appveyor.com/project/github-windows/visualstudio/builds/23437511/artifacts

If you could comment on #2305, that would be great. 😄

@pmunin

This comment has been minimized.

Copy link
Author

commented Mar 29, 2019

Just tested, works now! 👍 replied to #2305 as well. Thanks!

@meaghanlewis meaghanlewis added this to the 2.9.0 milestone Apr 3, 2019

@StanleyGoldman StanleyGoldman changed the title PR adding review comment request fails for HTTP enterprise server GitHub Enterprise over http unable to adding review comment Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.