New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username error icon displays by default #307

Closed
mponce1 opened this Issue May 18, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@mponce1
Contributor

mponce1 commented May 18, 2016

Steps to reproduce:

  1. Open visual studio
  2. Go to connect page
  3. Click on Github -> Connect

Expected result: Username error icon only displays after user tabs away from field or enters an invalid value.
Actual result: Error displays immediately when it opens. Tabbing away from the field clears the icon.

screen shot 2016-05-18 at 3 24 48 pm 1

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana May 18, 2016

Collaborator

@grokys Could this be related to #285?

Collaborator

shana commented May 18, 2016

@grokys Could this be related to #285?

@mponce1

This comment has been minimized.

Show comment
Hide comment
@mponce1

mponce1 May 19, 2016

Contributor

Also happens on Enterprise if you're already signed into Github and you go to Manage Connections -> Connect to Github.

screen shot 2016-05-18 at 5 06 50 pm

Contributor

mponce1 commented May 19, 2016

Also happens on Enterprise if you're already signed into Github and you go to Manage Connections -> Connect to Github.

screen shot 2016-05-18 at 5 06 50 pm

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys May 19, 2016

Contributor

Ignore my previous comment - yes I think this was caused by #285.

Contributor

grokys commented May 19, 2016

Ignore my previous comment - yes I think this was caused by #285.

grokys added a commit that referenced this issue May 19, 2016

@shana shana closed this in #313 May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment