New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login error messages not getting fully propagated to the UI #351

Closed
shana opened this Issue Jun 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@shana
Collaborator

shana commented Jun 9, 2016

When a user hasn't verified their email, octokit returns

{"message":"Validation Failed","errors":[{"resource":"OauthAccess","code":"custom","field":"user","message":"user must have a verified email address in order to authenticate via OAuth"}],"documentation_url":"https://developer.github.com/v3/oauth_authorizations/#get-or-create-an-authorization-for-a-specific-app"}    at Octokit.Connection.HandleErrors(IResponse response) in Y:\jenkins\workspace\GitHub for Visual Studio speakeasy jenkinskeep\submodules\octokit.net\Octokit\Http\Connection.cs:line 563

but our login UI just says "Could not connect to github.com". We need to propagate these messages properly so users don't get confused about why things are failing.

@shana shana added the bug label Jun 9, 2016

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jun 9, 2016

Contributor

👍 Yes, this bit me just the other day.

Contributor

grokys commented Jun 9, 2016

👍 Yes, this bit me just the other day.

@grokys grokys self-assigned this Jun 9, 2016

grokys added a commit that referenced this issue Jun 9, 2016

Show login failure message.
Initial fix for #351. Shows the error message when connection fails for
.com and enterprise.
@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jul 5, 2016

Contributor

Fixed by #352

Contributor

grokys commented Jul 5, 2016

Fixed by #352

@grokys grokys closed this Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment