New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PR template if it exists when creating PRs #463

Closed
shana opened this Issue Jul 29, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@shana
Collaborator

shana commented Jul 29, 2016

We're currently ignoring PULL_REQUEST_TEMPLATE.md and .github/* files in the PR creation form, and we should use templates to pre-fill the description, if the templates exist.

@shana shana added the enhancement label Jul 29, 2016

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jul 29, 2016

Contributor

Desktop's behavior is also often useful to me where it auto-fills the PR title/comments with information from the commits in the branch. I'm not sure what the algorithm is there though.

Contributor

grokys commented Jul 29, 2016

Desktop's behavior is also often useful to me where it auto-fills the PR title/comments with information from the commits in the branch. I'm not sure what the algorithm is there though.

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Jul 29, 2016

Collaborator

It does it if there's only one commit iirc. If there's more than one, it only fills in the title with the branch name. I usually don't use it because of that.

Collaborator

shana commented Jul 29, 2016

It does it if there's only one commit iirc. If there's more than one, it only fills in the title with the branch name. I usually don't use it because of that.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jul 30, 2016

Contributor

I find it quite useful, and I've been missing it when working with the new 2.0 RC. I agree that the template would be useful also. Not sure how the two could be combined...

Contributor

grokys commented Jul 30, 2016

I find it quite useful, and I've been missing it when working with the new 2.0 RC. I agree that the template would be useful also. Not sure how the two could be combined...

grokys added a commit that referenced this issue Aug 10, 2016

@shana shana closed this in #495 Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment