New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Pull Requests button in GitHub pane causes `ObjectDisposedException` #505

Closed
grokys opened this Issue Aug 17, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@grokys
Contributor

grokys commented Aug 17, 2016

On current master, if I have the GitHub pane open and click the "Pull Requests" button I get:

System.ObjectDisposedException occurred
  HResult=-2146232798
  Message=Cannot access a disposed object.
  ObjectName=""
  Source=System.Reactive.Linq
  StackTrace:
       at System.Reactive.Subjects.ReplaySubject`1.ReplayBufferBase.CheckDisposed()
       at System.Reactive.Subjects.ReplaySubject`1.ReplayBufferBase.OnCompleted()
       at System.Reactive.Subjects.ReplaySubject`1.OnCompleted()
       at GitHub.Collections.TrackingCollection`1.<Listen>b__36_2() in D:\projects\VisualStudio\src\GitHub.Exports.Reactive\Collections\TrackingCollection.cs:line 303
  InnerException: 

It doesn't happen every time. If it doesn't, close the pane and try again, or try restarting VS. After a few tries it should throw.

@grokys grokys added the bug label Aug 17, 2016

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 17, 2016

Contributor

Might be caused by clicking it before the PR list has finished loading? This seems to be the most reliable method to repro, though I think it's also happened when the list is loaded.

Contributor

grokys commented Aug 17, 2016

Might be caused by clicking it before the PR list has finished loading? This seems to be the most reliable method to repro, though I think it's also happened when the list is loaded.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 17, 2016

Contributor

Another crasher: clicking it before the PR list finished loading threw this:

System.ArgumentOutOfRangeException occurred
  HResult=-2146233086
  Message=Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
  ParamName=index
  Source=mscorlib
  StackTrace:
       at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
       at System.Collections.Generic.List`1.get_Item(Int32 index)
       at GitHub.Collections.TrackingCollection`1.RecalculateFilter(IList`1 list, Int32 index, Int32 start, Int32 end, Boolean force) in D:\projects\VisualStudio\src\GitHub.Exports.Reactive\Collections\TrackingCollection.cs:line 895
  InnerException: 
Contributor

grokys commented Aug 17, 2016

Another crasher: clicking it before the PR list finished loading threw this:

System.ArgumentOutOfRangeException occurred
  HResult=-2146233086
  Message=Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
  ParamName=index
  Source=mscorlib
  StackTrace:
       at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
       at System.Collections.Generic.List`1.get_Item(Int32 index)
       at GitHub.Collections.TrackingCollection`1.RecalculateFilter(IList`1 list, Int32 index, Int32 start, Int32 end, Boolean force) in D:\projects\VisualStudio\src\GitHub.Exports.Reactive\Collections\TrackingCollection.cs:line 895
  InnerException: 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment