New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide copy/open link when file not hosted on repo #530

Closed
paladique opened this Issue Aug 30, 2016 · 0 comments

Comments

Projects
2 participants
@paladique
Collaborator

paladique commented Aug 30, 2016

Steps to reproduce (all in Visual Studio)

  1. Open a solution that is hosted in a GitHub repo (Visual Studio should switch git context to hosted repo)
  2. Close solution
  3. Open a file that doesn't exist in the repo of the Git context
  4. Highlight over the file's text & right click to navigation to "Open in GitHub/Copy link"

Link contains last commit of repo.

Not sure the option to close/exit out of the context or repo when the solution is closed is available, might be a Visual Studio thing, but we could check that the current file exists in the repo and hide it if it doesn't for now.

@paladique paladique added the bug label Aug 30, 2016

@grokys grokys self-assigned this Feb 15, 2017

grokys added a commit that referenced this issue Feb 15, 2017

Hide copy/open link when file not hosted on repo.
Check to see if the current file is located in the active repository and
only show "Open on GitHub" and "Copy link to clipboard" context menus if
it is.

Fixes #530.

@grokys grokys added this to Done in 2.2.0.8 Feb 16, 2017

@grokys grokys moved this from Done to In Progress in 2.2.0.8 Feb 16, 2017

@jcansdale jcansdale closed this in #859 Feb 23, 2017

jcansdale added a commit that referenced this issue Feb 23, 2017

Hide copy/open link when file not hosted on repo. (#859)
Check to see if the current file is located in the active repository and
only show "Open on GitHub" and "Copy link to clipboard" context menus if
it is.

Fixes #530.

@paladique paladique moved this from In Progress to Done in 2.2.0.8 Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment