New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional exception in TrackingCollection. #597

Closed
grokys opened this Issue Oct 13, 2016 · 4 comments

Comments

4 participants
@grokys
Contributor

grokys commented Oct 13, 2016

I get very occasional exceptions in TrackingCollection - usually when the PR list is updating. Here's the details:

At TrackingCollection.cs line 476

System.ObjectDisposedException occurred
  HResult=-2146232798
  Message=Cannot access a disposed object.
Object name: 'TrackingCollection'.
  ObjectName=TrackingCollection
  Source=GitHub.Exports.Reactive
  StackTrace:
       at GitHub.Collections.TrackingCollection`1.RemoveItem(T item) in D:\projects\VisualStudio\src\GitHub.Exports.Reactive\Collections\TrackingCollection.cs:line 476
  InnerException: 

As you can see, the stack trace shows only the current method: RemoveItem.

This crashes VS.

@grokys grokys changed the title from Occasion exception in TrackingCollection. to Occasional exception in TrackingCollection. Oct 13, 2016

@grokys grokys added bug crash labels Oct 13, 2016

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Oct 13, 2016

Collaborator

Feels like a race condition between disposal of the current listeners in preparation for processing the new results and the current list still processing.

Collaborator

shana commented Oct 13, 2016

Feels like a race condition between disposal of the current listeners in preparation for processing the new results and the current list still processing.

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Oct 26, 2016

Contributor

I tried my best to reproduce this bug or see how it could happen and I checked the master and maintainer-workflow-diff branches. The only usages of RemoveItem() I could find are wrapped in try/catch blocks that swallow exceptions of type ObjectDisposedException. I'm not sure how you are getting that exception.

Contributor

StanleyGoldman commented Oct 26, 2016

I tried my best to reproduce this bug or see how it could happen and I checked the master and maintainer-workflow-diff branches. The only usages of RemoveItem() I could find are wrapped in try/catch blocks that swallow exceptions of type ObjectDisposedException. I'm not sure how you are getting that exception.

@paladique paladique added this to the Maintainer Workflow: The Road to MVP milestone Dec 6, 2016

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Dec 8, 2016

Contributor

Still getting this occasionally. The exception seems to be swallowed so it doesn't crash VS, but I'm worried that it might break the PR list.

Contributor

grokys commented Dec 8, 2016

Still getting this occasionally. The exception seems to be swallowed so it doesn't crash VS, but I'm worried that it might break the PR list.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jan 3, 2017

Contributor

Fixed by #742.

Contributor

grokys commented Jan 3, 2017

Fixed by #742.

@grokys grokys closed this Jan 3, 2017

@grokys grokys moved this from Not Started to Done in Maintainer workflow Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment