New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Publish to GitHub' panels TextBox styling not consistent with other controls #643

Closed
tocsoft opened this Issue Oct 25, 2016 · 5 comments

Comments

Projects
3 participants
@tocsoft
Contributor

tocsoft commented Oct 25, 2016

  • GitHub Extension version: v2.0.15.1
  • Visual Studio version: 2015 u3

Text boxes on Publish to GitHub panel are not in keeping to the same style as the rest of the panel/pane.

image

image

image

image

my expectation: (blue theme)

  • No rounded corners
  • Darker boarder
  • Yellow border on hover/focus

my expectation: (dark theme)

  • No rounded corners
  • Darker boarder
  • hover/focus boarder looks fine

(basically to be like the drop downs just above)

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 26, 2016

Contributor

Yeah, this stuff is a real PITA to get right as Team Explorer doesn't expose its styles for us to use AFAICT.

Contributor

grokys commented Oct 26, 2016

Yeah, this stuff is a real PITA to get right as Team Explorer doesn't expose its styles for us to use AFAICT.

@tocsoft

This comment has been minimized.

Show comment
Hide comment
@tocsoft

tocsoft Oct 26, 2016

Contributor

I can imagine it can get quite vexing at times... and i bet the fight starts again when the next version lands and they change their minds. :)

Its just minor thing really, but I felt it wanted tracking.

Contributor

tocsoft commented Oct 26, 2016

I can imagine it can get quite vexing at times... and i bet the fight starts again when the next version lands and they change their minds. :)

Its just minor thing really, but I felt it wanted tracking.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 26, 2016

Contributor

And yeah - they do change the styling from version to version: #551 :(

Contributor

grokys commented Oct 26, 2016

And yeah - they do change the styling from version to version: #551 :(

@grokys grokys added the cosmetic label Oct 26, 2016

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Oct 27, 2016

Contributor

So I did some spelunking with Snoop and dotPeek and I learned a few things that might help.

The Team Foundation controls don't seem to use any actual TextBlock controls. They always use Microsoft.TeamFoundation.Controls.WPF.LabeledTextBox. Which carries it's own xaml and internal styles, and is actually always yellow o_0, but that's how they avoid the text box prompt from fading into the background when the theme changes.

img
img

img
img

Other things I discovered that might be of use:

  • component/GitSharedResources.xaml in Microsoft.TeamFoundation.Git.Controls. There are some styles like PlainComboBox which could help synchronize with the styles per version of Visual Studio.
  • TeamFoundationColorProvider and TeamFoundationColors in Microsoft.TeamFoundation.Controls.WPF might be a way to get the same result in a way that might work on both versions of Visual Studio.
Contributor

StanleyGoldman commented Oct 27, 2016

So I did some spelunking with Snoop and dotPeek and I learned a few things that might help.

The Team Foundation controls don't seem to use any actual TextBlock controls. They always use Microsoft.TeamFoundation.Controls.WPF.LabeledTextBox. Which carries it's own xaml and internal styles, and is actually always yellow o_0, but that's how they avoid the text box prompt from fading into the background when the theme changes.

img
img

img
img

Other things I discovered that might be of use:

  • component/GitSharedResources.xaml in Microsoft.TeamFoundation.Git.Controls. There are some styles like PlainComboBox which could help synchronize with the styles per version of Visual Studio.
  • TeamFoundationColorProvider and TeamFoundationColors in Microsoft.TeamFoundation.Controls.WPF might be a way to get the same result in a way that might work on both versions of Visual Studio.
@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Oct 27, 2016

Contributor

Thanks for taking a look Stanley. Indeed looking in ILSpy, LabeledTextBox is actually public so we may be able to use that!

I'm not sure though about using styles from Team Foundation assemblies; I don't think these are considered public though that's a question for MS that I can ask.

Contributor

grokys commented Oct 27, 2016

Thanks for taking a look Stanley. Indeed looking in ILSpy, LabeledTextBox is actually public so we may be able to use that!

I'm not sure though about using styles from Team Foundation assemblies; I don't think these are considered public though that's a question for MS that I can ask.

@grokys grokys added this to Not Started in 2.2.0.8 Feb 16, 2017

grokys added a commit that referenced this issue Feb 21, 2017

@grokys grokys moved this from Not Started to In Progress in 2.2.0.8 Feb 21, 2017

@grokys grokys closed this in #874 Feb 24, 2017

@paladique paladique moved this from In Progress to Done in 2.2.0.8 Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment