New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design for start page clone dialog #684

Closed
donokuda opened this Issue Nov 10, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@donokuda
Member

donokuda commented Nov 10, 2016

Follow up to #670

@donokuda this branch won't build on 2015 but the xaml designer should be able to load the view. If not, just a mockup will do, we can fix it up ourselves. This is basically the clone dialog, only without the repository list and filter textbox, and instead just showing the name of the repository we're going to clone. Since the size of the window is pretty much fixed (because it has to accommodate the login dialog before), we have a lot of empty space that we need filling.

We should probably have:

  • The avatar that owns the account
  • The name of the account
  • The name of the repository
  • The url to it (just to be clear and you know gotta fill that space)
  • repo/lock/fork icons maybe?

Here's what I'm thinking the updated design could look like

@tocsoft

This comment has been minimized.

Show comment
Hide comment
@tocsoft

tocsoft Nov 10, 2016

Contributor

Is the full url really giving us any real benefit?

Would it make more sense instead to have instead of URL 🔗 https://github.com/{owner}/{repoName}
having Server 🔗 GitHub.com or for GHE Server 🔗 YourGHEServer.net

Contributor

tocsoft commented Nov 10, 2016

Is the full url really giving us any real benefit?

Would it make more sense instead to have instead of URL 🔗 https://github.com/{owner}/{repoName}
having Server 🔗 GitHub.com or for GHE Server 🔗 YourGHEServer.net

@donokuda

This comment has been minimized.

Show comment
Hide comment
@donokuda

donokuda Nov 10, 2016

Member

Is the full url really giving us any real benefit?

Would it make more sense instead to have instead of URL 🔗 https://github.com/{owner}/{repoName}
having Server 🔗 GitHub.com or for GHE Server 🔗 YourGHEServer.net

Showing just github.com or YourGHEServer.net instead of the full URL makes sense. If we do that, should we label it as "Source" instead of "URL?"

Member

donokuda commented Nov 10, 2016

Is the full url really giving us any real benefit?

Would it make more sense instead to have instead of URL 🔗 https://github.com/{owner}/{repoName}
having Server 🔗 GitHub.com or for GHE Server 🔗 YourGHEServer.net

Showing just github.com or YourGHEServer.net instead of the full URL makes sense. If we do that, should we label it as "Source" instead of "URL?"

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Nov 14, 2016

Collaborator

Showing just github.com or YourGHEServer.net instead of the full URL makes sense. If we do that, should we label it as "Source" instead of "URL?"

Source sounds appropriate 👍

Collaborator

shana commented Nov 14, 2016

Showing just github.com or YourGHEServer.net instead of the full URL makes sense. If we do that, should we label it as "Source" instead of "URL?"

Source sounds appropriate 👍

grokys added a commit that referenced this issue Nov 16, 2016

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Nov 17, 2016

Collaborator

For reference, this is what the create repository UI looks like right now.

7-create-repo

@donokuda What do you think of having this clone dialog more closely aligned in UI with the create repository dialog?

Collaborator

shana commented Nov 17, 2016

For reference, this is what the create repository UI looks like right now.

7-create-repo

@donokuda What do you think of having this clone dialog more closely aligned in UI with the create repository dialog?

@donokuda

This comment has been minimized.

Show comment
Hide comment
@donokuda

donokuda Nov 17, 2016

Member

What do you think of having this clone dialog more closely aligned in UI with the create repository dialog?

I like that idea. Here's a quick mock-up with what I'm thinking we should go towards:

image

I ended up keeping the full URL since it would be consistent with Microsoft displaying the full URL in their clone dialog. Also showed how we would end up wrapping if a url is extremely long.

Member

donokuda commented Nov 17, 2016

What do you think of having this clone dialog more closely aligned in UI with the create repository dialog?

I like that idea. Here's a quick mock-up with what I'm thinking we should go towards:

image

I ended up keeping the full URL since it would be consistent with Microsoft displaying the full URL in their clone dialog. Also showed how we would end up wrapping if a url is extremely long.

@tocsoft

This comment has been minimized.

Show comment
Hide comment
@tocsoft

tocsoft Nov 17, 2016

Contributor

Would have though in this context that Name should be labelled Repository as Name doesn't really explain what its a name of exactly.

With regards Organization should it not be Owner instead? That is unless we can detect the difference on this screen and switch between the 2 based on context.

Still not a fan of the Url defiantly prefer Source with domain.name. Just guessing (as I cant find the screen that actually has the full url on) I would have thought that MS has to have the full url as they don't have the same sort options GHfVS has to show an "exploded" rich set of context specific information about the repo/owner etc.

Contributor

tocsoft commented Nov 17, 2016

Would have though in this context that Name should be labelled Repository as Name doesn't really explain what its a name of exactly.

With regards Organization should it not be Owner instead? That is unless we can detect the difference on this screen and switch between the 2 based on context.

Still not a fan of the Url defiantly prefer Source with domain.name. Just guessing (as I cant find the screen that actually has the full url on) I would have thought that MS has to have the full url as they don't have the same sort options GHfVS has to show an "exploded" rich set of context specific information about the repo/owner etc.

@donokuda

This comment has been minimized.

Show comment
Hide comment
@donokuda

donokuda Nov 18, 2016

Member

Would have though in this context that Name should be labelled Repository as Name doesn't really explain what its a name of exactly.

With regards Organization should it not be Owner instead? That is unless we can detect the difference on this screen and switch between the 2 based on context.

👍 Agree on both. I've updated the mock to reflect your feedback as well as changing URL to Source.

image

Still not a fan of the Url defiantly prefer Source with domain.name. Just guessing (as I cant find the screen that actually has the full url on) I would have thought that MS has to have the full url as they don't have the same sort options GHfVS has to show an "exploded" rich set of context specific information about the repo/owner etc.

Yeah that makes sense, however I still would lean towards having the full URL since it communicates the exact source where the repo is coming from. That way, I'm more confident that I'm cloning the right repository.

Member

donokuda commented Nov 18, 2016

Would have though in this context that Name should be labelled Repository as Name doesn't really explain what its a name of exactly.

With regards Organization should it not be Owner instead? That is unless we can detect the difference on this screen and switch between the 2 based on context.

👍 Agree on both. I've updated the mock to reflect your feedback as well as changing URL to Source.

image

Still not a fan of the Url defiantly prefer Source with domain.name. Just guessing (as I cant find the screen that actually has the full url on) I would have thought that MS has to have the full url as they don't have the same sort options GHfVS has to show an "exploded" rich set of context specific information about the repo/owner etc.

Yeah that makes sense, however I still would lean towards having the full URL since it communicates the exact source where the repo is coming from. That way, I'm more confident that I'm cloning the right repository.

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Nov 22, 2016

Collaborator

That way, I'm more confident that I'm cloning the right repository.

Yeah, that's a good thought.

Collaborator

shana commented Nov 22, 2016

That way, I'm more confident that I'm cloning the right repository.

Yeah, that's a good thought.

@donokuda

This comment has been minimized.

Show comment
Hide comment
@donokuda

donokuda Dec 6, 2016

Member

Opened up #708 incorporating the design I posted above.

A couple of things to note I didn't explain that would be really nice (and isn't apart of my open PR):

  • The Repo icon changes between the book or a lock symbol depending if the repo is public or private respectively.
  • The organization symbol should update with the org avatar if it's available. If not, it should default to the group icon.
Member

donokuda commented Dec 6, 2016

Opened up #708 incorporating the design I posted above.

A couple of things to note I didn't explain that would be really nice (and isn't apart of my open PR):

  • The Repo icon changes between the book or a lock symbol depending if the repo is public or private respectively.
  • The organization symbol should update with the org avatar if it's available. If not, it should default to the group icon.
@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Dec 8, 2016

Contributor

The Repo icon changes between the book or a lock symbol depending if the repo is public or private respectively.
The organization symbol should update with the org avatar if it's available. If not, it should default to the group icon.

Unfortunately this info isn't currently available at the point that the dialog is shown. We're going to need to do a bit of a restructure of how we represent accounts, as the Account class is currently dependent on Reactive Extensions which won't be loaded at this point.

Contributor

grokys commented Dec 8, 2016

The Repo icon changes between the book or a lock symbol depending if the repo is public or private respectively.
The organization symbol should update with the org avatar if it's available. If not, it should default to the group icon.

Unfortunately this info isn't currently available at the point that the dialog is shown. We're going to need to do a bit of a restructure of how we represent accounts, as the Account class is currently dependent on Reactive Extensions which won't be loaded at this point.

@grokys grokys closed this in #690 Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment