New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted PR list crashes VS when GitHub pane closed and re-opened #737

Closed
grokys opened this Issue Dec 14, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented Dec 14, 2016

While testing #734 I came upon what I think is a bug in TrackingCollection. To repro:

  1. Check out #734
  2. Open the GitHub pane and sort PRs by "Least recently updated"
  3. Close the GitHub pane
  4. Click Pull Requests in Team Explorer to re-open the GitHub pane
  5. Exception:
Exception thrown: 'System.ArgumentException' in GitHub.App.dll

Additional information: Instance to copy from doesn't match this instance. this:(id:22 title:Fix CI for ultimate happiness created:2015-07-30 21:59:17Z updated:2015-07-30 22:00:49Z) other:(id:732 title:Pull Request Filtering created:2016-12-12 15:53:29Z updated:2016-12-14 09:58:08Z)

   at GitHub.Models.PullRequestModel.CopyFrom(IPullRequestModel other) in D:\projects\VisualStudio\src\GitHub.App\Models\PullRequestModel.cs:line 30

@grokys grokys added the crash label Dec 14, 2016

@grokys grokys added this to the Maintainer Workflow: Beta milestone Dec 14, 2016

shana added a commit that referenced this issue Dec 15, 2016

Clear the sort cache when changing the sorter
Fixes #737

Also make sure we scan the whole range of items that have potentially
been affected by an item move due to updated sorting fields.
Clean up some tests and add more tests.

shana added a commit that referenced this issue Dec 15, 2016

Clear the sort cache when changing the sorter
Fixes #737

Also make sure we scan the whole range of items that have potentially
been affected by an item move due to updated sorting fields.
Clean up some tests and add more tests.

@grokys grokys closed this in #744 Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment