New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR list causes VS to hang when checking out PR in project with lots of PRs #738

Closed
grokys opened this Issue Dec 14, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Dec 14, 2016

Steps to reproduce (note you may need to try this a few times - it doesn't always happen):

  1. Check out aspnet/Mvc
  2. Run with "break on CLR exceptions" disabled
  3. Click on a PR
  4. Click on the checkout link for the PR
  5. Watch VS hang for a good amount of time

If you look at the output window, about 2250 ObjectDisposedExceptions are being thrown by TrackingCollection.RemoveItem. These exceptions are being caught in ModelService.GetPullRequests but I assume the sheer amount of exceptions being thrown and caught is causing a hang.

@grokys grokys added this to the Maintainer Workflow: Beta milestone Dec 14, 2016

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Dec 14, 2016

Contributor

I almost got a unit test where I can reproduce the scenario.

Contributor

StanleyGoldman commented Dec 14, 2016

I almost got a unit test where I can reproduce the scenario.

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Dec 14, 2016

Contributor

You can also reproduce the scenario by performing any activity in the git repo with the view open.
For instance by checking in a simple file using the command line.

Contributor

StanleyGoldman commented Dec 14, 2016

You can also reproduce the scenario by performing any activity in the git repo with the view open.
For instance by checking in a simple file using the command line.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jan 3, 2017

Contributor

Fixed by #742

Contributor

grokys commented Jan 3, 2017

Fixed by #742

@grokys grokys closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment