New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File icon on PR details view looks bad on dark theme when highlight is on #793

Closed
shana opened this Issue Jan 24, 2017 · 0 comments

Comments

Projects
2 participants
@shana
Collaborator

shana commented Jan 24, 2017

The text is ok, but the icon isn't getting updated for the lighter background color when a file is highlighted on the list.

image

@shana shana added the cosmetic label Jan 24, 2017

@grokys grokys added this to Not Started in 2.2.0.8 Feb 16, 2017

@grokys grokys moved this from Not Started to In Progress in 2.2.0.8 Feb 16, 2017

grokys added a commit that referenced this issue Feb 16, 2017

Make OcticonImage inherit Foreground.
Don't set the `OcticonImage.Foreground` property in the `OcticonImage`
default theme: this way it inherits the foreground color which is
usually what is wanted. Fixes #793.

@grokys grokys self-assigned this Feb 20, 2017

@paladique paladique closed this in #867 Feb 23, 2017

@paladique paladique moved this from In Progress to Done in 2.2.0.8 Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment