New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub provider on Start Page should use the new Clone API #800

Closed
prasethu opened this Issue Jan 26, 2017 · 4 comments

Comments

Projects
3 participants
@prasethu
Collaborator

prasethu commented Jan 26, 2017

In VS 2017, we've introduced a new Clone API that enables cloning in Team Explorer and returns progress through an IProgress.

To enable the Start Page to display progress in the status bar, the GitHub provider should pass on the IProgress to the Clone API.

A sample usage of the new Clone API can be found here:
https://github.com/prasethu/CloneAPISample

Specifically this file: CloneAPISample/VSIXProject2/Command1.cs

@prasethu

This comment has been minimized.

Show comment
Hide comment
Collaborator

prasethu commented Jan 26, 2017

@shana shana added the enhancement label Jan 26, 2017

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Jan 27, 2017

Collaborator

@prasethu Thanks for the heads up, we'll get this included on our roadmap!

Collaborator

shana commented Jan 27, 2017

@prasethu Thanks for the heads up, we'll get this included on our roadmap!

@shana shana added this to Ideas in Feature work planning Jan 31, 2017

@shana shana moved this from Big Ideas to Scheduled in Feature work planning Jan 31, 2017

grokys added a commit that referenced this issue Feb 7, 2017

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 7, 2017

Contributor

@prasethu - I've implemented that here:

49a16ae#diff-37b2ed98a57be40299d610a06bbc51b8R68

This seems to work, however I'm not sure if we should be creating a new Progress<ServiceProgressData> there (as in your sample) or if the intention was that we should be passing on the IProgress<ServiceProgressData> that is passed to us in AcquireCodeContainerAsync?

Contributor

grokys commented Feb 7, 2017

@prasethu - I've implemented that here:

49a16ae#diff-37b2ed98a57be40299d610a06bbc51b8R68

This seems to work, however I'm not sure if we should be creating a new Progress<ServiceProgressData> there (as in your sample) or if the intention was that we should be passing on the IProgress<ServiceProgressData> that is passed to us in AcquireCodeContainerAsync?

@grokys grokys closed this in 49a16ae Feb 13, 2017

@grokys grokys added this to Done in 2.2.0.8 Feb 16, 2017

@prasethu

This comment has been minimized.

Show comment
Hide comment
@prasethu

prasethu Feb 21, 2017

Collaborator

@grokys Sorry about the late response but yes you should be passing it over to the clone api.

Collaborator

prasethu commented Feb 21, 2017

@grokys Sorry about the late response but yes you should be passing it over to the clone api.

@grokys grokys reopened this Feb 22, 2017

@grokys grokys moved this from Done to In Progress in 2.2.0.8 Feb 22, 2017

grokys added a commit that referenced this issue Feb 23, 2017

In order to fix #800, we need to pass a progress object to `IGitActio…
…nsExt.CloneAsync`. This was not easy before as the call to `CloneAsync` was hidden in the Clone button command in RepositoryCloneService. This commit:

- Stops the `RepositoryCloneViewModel` from doing the clone itself
- Adds a `DialogService` to show the clone dialogs and return their results
- Adds a "progress" parameter to `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone`
- Makes the connect and start pages use the dialog service to show the dialog and then call the clone service

This commit also fixes #849:

- `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` now return a task that doesn't complete until the clone is complete
- Changes `GitHubConnectSection` to have a `Clone` command which disabled itself while the clone is in progress.

@grokys grokys closed this in #881 Feb 27, 2017

@paladique paladique moved this from In Progress to Done in 2.2.0.8 Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment