New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a better way of opening the PR on the website from the details view #803

Closed
shana opened this Issue Jan 26, 2017 · 3 comments

Comments

Projects
3 participants
@shana
Collaborator

shana commented Jan 26, 2017

Right now the only way to open the PR on the website from the PR details view is to click on the "View conversation on GitHub" link.

image

The position of the View Conversation link means that it's not the main thing the user is going to see (it's down below and its position changes depending on how big the PR description is. Because it's at the end of the PR description, it looks like it's something that's a part of the description, and not a common action to perform.

Feels like we need a better way to open the browser in this context, something like:

  • Link popout or GitHub icon on the toolbar for going to the website
    • GitHub icon would allow us to always go to the website from any pane view
  • Right click on the PR title
@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Feb 10, 2017

Contributor

Even simpler would be to hyperlink the hash in Pull Request #787. I think people expect a link when they see a hash.

We should probably hyperlink the Fixes #778 Fixes #779 references as well...

Contributor

jcansdale commented Feb 10, 2017

Even simpler would be to hyperlink the hash in Pull Request #787. I think people expect a link when they see a hash.

We should probably hyperlink the Fixes #778 Fixes #779 references as well...

@grokys grokys added this to Not Started in 2.3.x Feb 28, 2017

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jul 6, 2017

Contributor

I think this was at least partially addressed by #836. Should we close this issue?

Contributor

grokys commented Jul 6, 2017

I think this was at least partially addressed by #836. Should we close this issue?

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jul 6, 2017

Contributor

Yes, I think #836 addresses it. What do you think @shana?

RE my comment about hyperlinks, I can see a day where # hyperlinks navigate within the GitHub pane. Having a consistent navigate to equivalent page on github.com (like we do in #836) makes sense.

Contributor

jcansdale commented Jul 6, 2017

Yes, I think #836 addresses it. What do you think @shana?

RE my comment about hyperlinks, I can see a day where # hyperlinks navigate within the GitHub pane. Having a consistent navigate to equivalent page on github.com (like we do in #836) makes sense.

@grokys grokys closed this Aug 21, 2017

@grokys grokys moved this from Not Started to Done in 2.3.x Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment