Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Should return to PR list after creating a PR #805
Stays on PR Creation View
Goes to PR List View
Ah, so it is the problem where there's two views of the same type being pushed to the navigation history. When it goes "back", it goes back to the previous creation view that was pushed. Legit bug! This is likely easy to reproduce by just clicking "Refresh" when in the creation view, and then hitting back - it's likely that it will just go back to the "previous" creation view instead of the PR list.
The creation view always causes a new view to be pushed, however: https://github.com/github/VisualStudio/blob/master/src/GitHub.App/Controllers/NavigationController.cs#L69.
It's fine to create a new view in this case and just throw the current view data away, but if the new view is of the same type as the current view, then we should not be adding it twice to the history, we should be popping the existing one and pushing the new one.