New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the default and context menu behaviours of the PR details changes list #817

Closed
shana opened this Issue Jan 31, 2017 · 3 comments

Comments

Projects
3 participants
@shana
Collaborator

shana commented Jan 31, 2017

The list of files that have been changed in the PR details view currently have a context menu that contains "Open" and "Compare". This is a bit confusing depending on whether the PR branch is checked out or not, we should make these actions clearer, so here's a proposal:

  • Default action (double click) is always to open a diff of the file
  • Context menu entry "Preview" always opens a temporary copy of the file (our current "Open" behaviour)
  • Context menu entry "Open" is only available if the PR branch is checked out, and it opens the actual real file that is on the local clone (regardless of whether a solution is opened or not)

Context menu would also contain #816

Thoughts?

@shana shana added the enhancement label Jan 31, 2017

@shana shana added this to Improvements in Feature work planning Jan 31, 2017

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Feb 13, 2017

Contributor

This is my no.1 usability issue at the moment. The fact that there's no way to open the actual real file and you can't even copy/paste the file name to find it is a pain!

I agree pretty much with your list (the current UI is definitely confusing). Here's your list with a few tweaks.

  • Default action (double click) is always to open a diff of the file
  • If the PR branch is checked out, the right hand file is live/editable (this is really handy).
  • Having a "Preview" option can be misleading because live warnings/errors are missing (but the code still looks the same). The user can already preview the file via diff, so I'd be inclined to remove this option.
  • Context menu entry "Open" is only available if the PR branch is checked out, and it opens the actual real file that is on the local clone (regardless of whether a solution is opened or not).

Does that make sense? 😄

Contributor

jcansdale commented Feb 13, 2017

This is my no.1 usability issue at the moment. The fact that there's no way to open the actual real file and you can't even copy/paste the file name to find it is a pain!

I agree pretty much with your list (the current UI is definitely confusing). Here's your list with a few tweaks.

  • Default action (double click) is always to open a diff of the file
  • If the PR branch is checked out, the right hand file is live/editable (this is really handy).
  • Having a "Preview" option can be misleading because live warnings/errors are missing (but the code still looks the same). The user can already preview the file via diff, so I'd be inclined to remove this option.
  • Context menu entry "Open" is only available if the PR branch is checked out, and it opens the actual real file that is on the local clone (regardless of whether a solution is opened or not).

Does that make sense? 😄

@jcansdale jcansdale self-assigned this Feb 13, 2017

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Feb 15, 2017

Contributor

I've prototyped the editable diff/file functionality in 2cd47ab. If the current branch is up to date, a live editable diff/file will be opened (I find being able to edit a diff particularly useful).

Here's a pre-built version if you'd like to give it a try:
GitHub.VisualStudio.zip

Having something to play with can help refine ideas. 😄

Contributor

jcansdale commented Feb 15, 2017

I've prototyped the editable diff/file functionality in 2cd47ab. If the current branch is up to date, a live editable diff/file will be opened (I find being able to edit a diff particularly useful).

Here's a pre-built version if you'd like to give it a try:
GitHub.VisualStudio.zip

Having something to play with can help refine ideas. 😄

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 15, 2017

Contributor

Related: #801

Contributor

grokys commented Feb 15, 2017

Related: #801

@grokys grokys added this to Not Started in 2.3.x Feb 28, 2017

@grokys grokys removed this from Not Started in 2.3.x Mar 9, 2017

@grokys grokys added this to Not Started in 2.2.0.9 Mar 9, 2017

grokys added a commit that referenced this issue Mar 21, 2017

Only enable Open file when branch checked out.
In the Pull Request Details view, disable the Open File context menu for
files unless the PR branch is checked out and when opening a file, open
the file in the working directory.

Fixes #801
Fixes #817

@jcansdale jcansdale closed this in #930 Mar 22, 2017

@grokys grokys moved this from Not Started to In Progress in 2.2.0.9 Mar 22, 2017

@paladique paladique moved this from In Progress to Done in 2.2.0.9 Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment