New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link buttons on PR list don't say what button will do #824

Closed
jcansdale opened this Issue Jan 31, 2017 · 5 comments

Comments

Projects
3 participants
@jcansdale
Contributor

jcansdale commented Jan 31, 2017

  • GitHub Extension for Visual Studio version: 2.2.0.6
  1. Hover over PR in list
  2. See tooltip with same text as link/button.

image

I expected the tooltip to be a description of what would happen if you click on the link.
Something like: Check out pull request locally View pull request details.

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Feb 1, 2017

Collaborator

Ah, eh, indeed. I think we were using it to display the full PR title in case it got truncated by the limited horizontal spacing. That was before we had a details view, though, so having the tooltip be more explicit about what it does would be more useful here, I agree.

Collaborator

shana commented Feb 1, 2017

Ah, eh, indeed. I think we were using it to display the full PR title in case it got truncated by the limited horizontal spacing. That was before we had a details view, though, so having the tooltip be more explicit about what it does would be more useful here, I agree.

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Feb 1, 2017

Collaborator

I believe we always capitalize Pull Request because it's a Thing(tm), so maybe "View Pull Request details"? Does that look weird, with everything but details capitalized?

Collaborator

shana commented Feb 1, 2017

I believe we always capitalize Pull Request because it's a Thing(tm), so maybe "View Pull Request details"? Does that look weird, with everything but details capitalized?

@jcansdale jcansdale added the cosmetic label Feb 1, 2017

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Feb 1, 2017

Contributor

No, I think "View Pull Request details", looks okay.

I guess the # links should also say: "View Pull Request on GitHub"?

Contributor

jcansdale commented Feb 1, 2017

No, I think "View Pull Request details", looks okay.

I guess the # links should also say: "View Pull Request on GitHub"?

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Feb 1, 2017

Collaborator

I guess the # links should also say: "View Pull Request on GitHub"?

Yup, sounds like a good idea!

Collaborator

shana commented Feb 1, 2017

I guess the # links should also say: "View Pull Request on GitHub"?

Yup, sounds like a good idea!

@grokys grokys added this to In Progress in 2.2.0.8 Feb 16, 2017

@grokys grokys moved this from In Progress to Done in 2.2.0.8 Feb 27, 2017

@grokys grokys moved this from Done to Testing in 2.2.0.8 Feb 27, 2017

@grokys grokys moved this from Testing to In Progress in 2.2.0.8 Feb 27, 2017

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Feb 27, 2017

Contributor

Closed by #827.

Contributor

grokys commented Feb 27, 2017

Closed by #827.

@grokys grokys closed this Feb 27, 2017

@grokys grokys moved this from In Progress to Done in 2.2.0.8 Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment