New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login dialog hangs when max 2FA login attempts is exceeded #829

Closed
grokys opened this Issue Feb 2, 2017 · 0 comments

Comments

Projects
1 participant
@grokys
Contributor

grokys commented Feb 2, 2017

Hello! Please read the contributing guidelines before submitting an issue regarding the GitHub Extension for Visual Studio.

  • GitHub Extension for Visual Studio version: 2.2.0.6
  • Visual Studio version: 2015

What happened (with steps, logs and screenshots, if possible)

  • Log in with a user that has 2FA enabled
  • Enter an invalid 2FA code multiple times
  • When the max login attempts has been exceeded the button stays spinning and no error is displayed

The dialog is still closable in this state but an error should be displayed.

@grokys grokys added the bug label Feb 2, 2017

@grokys grokys self-assigned this Feb 2, 2017

grokys added a commit that referenced this issue Feb 9, 2017

Handle errors in 2FA flow.
Handle non 2FA-errors in the 2FA flow. When such an error occurs, the
user is taken back to the username/password view and an error message is
shown. Fixes #829. Fixes #19.

@grokys grokys added this to Not Started in 2.3.x Feb 28, 2017

@grokys grokys moved this from Not Started to In Progress in 2.3.x May 5, 2017

@grokys grokys closed this in #845 Jun 19, 2017

@grokys grokys moved this from In Progress to Done in 2.3.x Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment