New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copy/open link aware of submodules #882

Closed
jcansdale opened this Issue Feb 23, 2017 · 1 comment

Comments

Projects
2 participants
@jcansdale
Contributor

jcansdale commented Feb 23, 2017

At the moment when you try to copy/open a link for a file that's within a submodule, the generated link is broken.

We could:

  1. Add full submodule support for link generation.
  2. Detect when a file is from a submodule and disable link generation (see #859).

I'd be inclined start off with 2, since broken links are a bug.

@jcansdale jcansdale added the bug label Feb 23, 2017

@grokys grokys added this to Not Started in 2.3.x Feb 28, 2017

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 21, 2017

Contributor

Fixed by #1100

Contributor

grokys commented Aug 21, 2017

Fixed by #1100

@grokys grokys closed this Aug 21, 2017

@grokys grokys moved this from Not Started to Done in 2.3.x Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment