New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Details compares wrong version after pull #901

Closed
grokys opened this Issue Mar 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@grokys
Contributor

grokys commented Mar 2, 2017

After a pull is carried out in the PR details view, comparing file contents show the diff from before the pull. Going back to the PR list and reopening the PR seems to fix it.

@grokys grokys added the bug label Mar 2, 2017

@grokys grokys self-assigned this Mar 2, 2017

grokys added a commit that referenced this issue Mar 2, 2017

Compare IPullRequestModel by ref in setter.
PullRequestModel overrides Equals such that two PRs with the same number are
considered equal. This was causing the Model not to be updated on refresh: we need to use ReferenceEquals. Fixes #901

@jcansdale jcansdale closed this in #903 Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment