New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom controls no longer have Automation IDs #969

Closed
paladique opened this Issue May 1, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@paladique
Collaborator

paladique commented May 1, 2017

While running GHfVS on master, I noticed that things like the GitHubPaneView and the PullRequestListView no longer have automation ids like they did in 2.2.0.8. They also seem to be missing in 2.2.0.10. Controls within those views (ie: Create new button in the PR list view) still have their automation ids.

@paladique paladique added the bug label May 1, 2017

@paladique

This comment has been minimized.

Show comment
Hide comment
@paladique

paladique May 1, 2017

Collaborator

After some more digging, this seems to have happened after #947 was merged.

Collaborator

paladique commented May 1, 2017

After some more digging, this seems to have happened after #947 was merged.

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale May 2, 2017

Contributor

Very sorry is this is something I broke! 😕

Contributor

jcansdale commented May 2, 2017

Very sorry is this is something I broke! 😕

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana May 2, 2017

Collaborator

Ah, the projects were moved but they didn't include all the required IDs? This is definitely something we should catch in QA before shipping a thing! We're aiming to get a 2.2.0.11 out the door with a hotfix, @paladique do you want to include the missing IDs there or just fix on master and wait for the next one?

Collaborator

shana commented May 2, 2017

Ah, the projects were moved but they didn't include all the required IDs? This is definitely something we should catch in QA before shipping a thing! We're aiming to get a 2.2.0.11 out the door with a hotfix, @paladique do you want to include the missing IDs there or just fix on master and wait for the next one?

@paladique

This comment has been minimized.

Show comment
Hide comment
@paladique

paladique May 2, 2017

Collaborator

@shana I can fix on master and wait for the next one, no need to hold it up. I can alter the control searching for now. The strange thing, which is pointing to no obvious fix, is that it's only happening to top level panels, for example: the PRListView panel doesn't have an id, but the controls (create new link, filters) within it does.

Collaborator

paladique commented May 2, 2017

@shana I can fix on master and wait for the next one, no need to hold it up. I can alter the control searching for now. The strange thing, which is pointing to no obvious fix, is that it's only happening to top level panels, for example: the PRListView panel doesn't have an id, but the controls (create new link, filters) within it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment