New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2017 repository listing spams the log with NRE when registry key is not found #978

Closed
shana opened this Issue May 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@shana
Collaborator

shana commented May 4, 2017

Looks like our 2017 codepath for listing repositories from the registry is not handling things right if the key doesn't exist (even though it probably doesn't crash, it spams the log with exceptions).

Error loading the repository list from the registry 'System.NullReferenceException: Object reference not set to an instance of an object.
   at GitHub.TeamFoundation.RegistryHelper.PokeTheRegistryForRepositoryList() in Y:\jenkins\workspace\GitHub for Visual Studio speakeasy jenkinskeep\src\GitHub.TeamFoundation.15\RegistryHelper.cs:line 26
   at GitHub.Services.VSGitServices.GetKnownRepositories() in Y:\jenkins\workspace\GitHub for Visual Studio speakeasy jenkinskeep\src\GitHub.TeamFoundation.14\Services\VSGitServices.cs:line 118'

@shana shana added the bug label May 4, 2017

@shana

This comment has been minimized.

Collaborator

shana commented May 4, 2017

From #948

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS Dec 2, 2017

@grokys grokys self-assigned this Dec 11, 2017

grokys added a commit that referenced this issue Dec 12, 2017

Handle null return values from registry methods.
`RegistryKey.OpenSubKey` can return null, check for null values before trying to do anything.

Fixes #978

@grokys grokys moved this from Medium Priority to In Progress in BUGS Dec 12, 2017

@grokys grokys closed this in #1378 Dec 13, 2017

BUGS automation moved this from In Progress to Done Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment