New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent threading error when cloning. #1065

merged 1 commit into from Jul 13, 2017


None yet
2 participants

grokys commented Jul 12, 2017

@tierninho was experiencing crashes when cloning. Though I couldn't reproduce this locally, I paired with him and saw that for some reason repositories.OriginalCompleted on his machine was completing on a non-UI thread.

Fixes #1064

@grokys grokys requested review from paladique and jcansdale Jul 12, 2017


I need to write a bunch of Rx code before this becomes intuitive! Does Rx default to using the thread pool or the current thread context? 👍 from me if it fixes it.

@jcansdale jcansdale merged commit 3654a52 into master Jul 13, 2017

5 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
VisualStudio Build #7265561 succeeded in 96s
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
jenkins/build_log Jenkins Build Log

@jcansdale jcansdale deleted the fixes/1064-clone-crash branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment